RE: [PATCH] amd64_edac - Add Family 17h Model 70h PCI IDs

Ghannam, Yazen
2019-09-04T22:21:53Z

> -----Original Message-----
> From: linux-edac-owner@vger.kernel.org <linux-edac-owner@vger.kernel.org> On Behalf Of Borislav Petkov
> Sent: Wednesday, September 4, 2019 4:53 PM
> To: Isaac Vaughn <isaac.vaughn@Knights.ucf.edu>; Ghannam, Yazen <Yazen.Ghannam@amd.com>
> Cc: trivial@kernel.org; linux-edac@vger.kernel.org
> Subject: Re: [PATCH] amd64_edac - Add Family 17h Model 70h PCI IDs
>
> Hi Isaac,
>
> On Wed, Sep 04, 2019 at 09:13:47PM +0000, Isaac Vaughn wrote:
> > I noticed the current EDAC driver doesn't support the new Zen 2 (model
> > 70h) processors, so I patched the new device ids in. The changes are
> > minimal, I merely extended the existing enums with information from
> > the new models.
>
> Makes sense to me.
>
> @Yazen, ACK?

The new PCI IDs are correct. However, we also need Device 18h Function 3
for amd64_edac_mod to function. I don't see a commit upstream that adds
this.

Isaac,
Could you please add the Function 3 as well? Please see the following for
reference.

be3518a16ef2 ("x86/amd_nb: Add PCI device IDs for family 17h, model 30h")

Thank you!

-Yazen