From: Borislav Petkov <bp@alien8.de>
To: Sherry Sun <sherry.sun@nxp.com>
Cc: "mchehab@kernel.org" <mchehab@kernel.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"james.morse@arm.com" <james.morse@arm.com>,
"rrichter@marvell.com" <rrichter@marvell.com>,
"michal.simek@xilinx.com" <michal.simek@xilinx.com>,
"manish.narani@xilinx.com" <manish.narani@xilinx.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>, Frank Li <frank.li@nxp.com>
Subject: Re: [PATCH v2] EDAC: synopsys: Fix the wrong call of pinf->col parameter
Date: Mon, 16 Mar 2020 11:43:56 +0100 [thread overview]
Message-ID: <20200316104356.GH26126@zn.tnic> (raw)
In-Reply-To: <AM6PR04MB658495A13744517A6E263D2292F90@AM6PR04MB6584.eurprd04.prod.outlook.com>
On Mon, Mar 16, 2020 at 01:30:39AM +0000, Sherry Sun wrote:
> Maybe you misunderstood the handle_error(), this function has already
> distinguished between Zynq and ZynqMP through priv->p_data->quirks.
> And what I am doing in this patch is to remove the useless pinf->col in ZynqMP
> part, which won't break the Zynq part.
Ok, I see it now, thanks for clarifying.
Now, in your v2 pls fix this check in handle_error():
if (!priv->p_data->quirks) {
to *actually* *explicitly* check that the platform for which
this function is called, really supports interrupts, i.e.,
DDR_ECC_INTR_SUPPORT, and not that the ->quirks thing is != 0. Like the
rest of the code does.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-03-16 10:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 2:16 [PATCH v2] EDAC: synopsys: Fix the wrong call of pinf->col parameter Sherry Sun
2020-03-09 8:44 ` Manish Narani
2020-03-15 19:50 ` Borislav Petkov
2020-03-16 1:30 ` Sherry Sun
2020-03-16 10:43 ` Borislav Petkov [this message]
2020-03-16 12:28 ` Sherry Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316104356.GH26126@zn.tnic \
--to=bp@alien8.de \
--cc=frank.li@nxp.com \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manish.narani@xilinx.com \
--cc=mchehab@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=rrichter@marvell.com \
--cc=sherry.sun@nxp.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox