From: Borislav Petkov <bp@alien8.de>
To: Alison Wang <alison.wang@nxp.com>, James Morse <james.morse@arm.com>
Cc: mchehab@kernel.org, tony.luck@intel.com, rrichter@marvell.com,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] edac: nxp: Add L1 and L2 error detection for A53 and A72 cores
Date: Sat, 15 Aug 2020 10:41:57 +0200 [thread overview]
Message-ID: <20200815084157.GC25814@zn.tnic> (raw)
In-Reply-To: <20200709082215.12829-1-alison.wang@nxp.com>
On Thu, Jul 09, 2020 at 04:22:15PM +0800, Alison Wang wrote:
> Add error detection for A53 and A72 cores. Hardware error injection is
> supported on A53. Software error injection is supported on both.
> For hardware error injection on A53 to work, proper access to
> L2ACTLR_EL1, CPUACTLR_EL1 needs to be granted by EL3 firmware. This is
> done by making an SMC call in the driver. Failure to enable access
> disables hardware error injection. For error detection to work, another
> SMC call enables access to L2ECTLR_EL1.
>
> It is for NXP's Layerscape family LS1043A, LS1046A, LS2088A and LX2160A.
>
> Signed-off-by: York Sun <york.sun@nxp.com>
> Signed-off-by: Alison Wang <alison.wang@nxp.com>
> ---
> .../bindings/edac/cortex-arm64-edac.txt | 40 +
> drivers/edac/Kconfig | 7 +
> drivers/edac/Makefile | 1 +
> drivers/edac/cortex_arm64_l1_l2.c | 738 ++++++++++++++++++
> drivers/edac/cortex_arm64_l1_l2.h | 54 ++
> 5 files changed, 840 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/edac/cortex-arm64-edac.txt
> create mode 100644 drivers/edac/cortex_arm64_l1_l2.c
> create mode 100644 drivers/edac/cortex_arm64_l1_l2.h
This needs James to have a look at.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-08-15 22:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 8:22 [PATCH] edac: nxp: Add L1 and L2 error detection for A53 and A72 cores Alison Wang
2020-08-15 8:41 ` Borislav Petkov [this message]
2020-08-21 11:38 ` James Morse
2020-08-25 2:31 ` [EXT] " Alison Wang
2020-08-25 13:18 ` James Morse
2020-08-26 3:03 ` Alison Wang
2020-08-27 10:40 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200815084157.GC25814@zn.tnic \
--to=bp@alien8.de \
--cc=alison.wang@nxp.com \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rrichter@marvell.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox