From: Borislav Petkov <bp@alien8.de>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Hulk Robot <hulkci@huawei.com>,
Robert Richter <rrichter@marvell.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Tony Luck <tony.luck@intel.com>,
linux-edac@vger.kernel.org
Subject: Re: [PATCH -next] EDAC, thunderx: Make symbol 'lmc_dfs_ents' static
Date: Mon, 17 Aug 2020 10:49:35 +0200 [thread overview]
Message-ID: <20200817084935.GB549@zn.tnic> (raw)
In-Reply-To: <20200714142308.46612-1-weiyongjun1@huawei.com>
On Tue, Jul 14, 2020 at 10:23:08PM +0800, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/edac/thunderx_edac.c:457:22: warning:
> symbol 'lmc_dfs_ents' was not declared. Should it be static?
>
> Symbol 'lmc_dfs_ents' is not used outside of thunderx_edac.c, so
> marks it static.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/edac/thunderx_edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/thunderx_edac.c b/drivers/edac/thunderx_edac.c
> index 4af9744cc6d0..0eb5eb97fd74 100644
> --- a/drivers/edac/thunderx_edac.c
> +++ b/drivers/edac/thunderx_edac.c
> @@ -454,7 +454,7 @@ DEBUGFS_STRUCT(inject_int, 0200, thunderx_lmc_inject_int_write, NULL);
> DEBUGFS_STRUCT(inject_ecc, 0200, thunderx_lmc_inject_ecc_write, NULL);
> DEBUGFS_STRUCT(int_w1c, 0400, NULL, thunderx_lmc_int_read);
>
> -struct debugfs_entry *lmc_dfs_ents[] = {
> +static struct debugfs_entry *lmc_dfs_ents[] = {
> &debugfs_mask0,
> &debugfs_mask2,
> &debugfs_parity_test,
Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2020-08-17 8:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 14:23 [PATCH -next] EDAC, thunderx: Make symbol 'lmc_dfs_ents' static Wei Yongjun
2020-07-27 13:56 ` Robert Richter
2020-08-17 8:49 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817084935.GB549@zn.tnic \
--to=bp@alien8.de \
--cc=hulkci@huawei.com \
--cc=linux-edac@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rrichter@marvell.com \
--cc=tony.luck@intel.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox