From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A12FC4727F for ; Mon, 28 Sep 2020 12:05:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE29D2100A for ; Mon, 28 Sep 2020 12:05:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="pIs6DGm6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726597AbgI1MFN (ORCPT ); Mon, 28 Sep 2020 08:05:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726565AbgI1MFM (ORCPT ); Mon, 28 Sep 2020 08:05:12 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75610C061755; Mon, 28 Sep 2020 05:05:12 -0700 (PDT) Received: from zn.tnic (p200300ec2f072200e7db2dcfbd154ae2.dip0.t-ipconnect.de [IPv6:2003:ec:2f07:2200:e7db:2dcf:bd15:4ae2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id E32D41EC0299; Mon, 28 Sep 2020 14:05:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1601294710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=44nAg9CdaxdFx7/RfjaA6M4aP2DlupCxNU/SRzXgphU=; b=pIs6DGm6aKFUzC7aC4QQBTgP7xfvVRCi7ALKiflT6HG69Xv+j+vJEfSovaqiCL2mXkx9qh 6iSCNYE1+fW7S9DMEaJtEpSuyIy7yOqsHnADz1iDp69TUIGG68rjGXaRZ7uQkWuuKJIDhf 3jcoAx1N9TzosGqThGX5HyWrlAwcsxI= Date: Mon, 28 Sep 2020 14:05:00 +0200 From: Borislav Petkov To: Shuah Khan Cc: mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com, rric@kernel.org, gregkh@linuxfoundation.org, keescook@chromium.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/11] drivers/edac: convert pci counters to counter_atomic32 Message-ID: <20200928120500.GA8151@zn.tnic> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Fri, Sep 25, 2020 at 05:47:25PM -0600, Shuah Khan wrote: > counter_atomic* is introduced to be used when a variable is used as > a simple counter and doesn't guard object lifetimes. This clearly > differentiates atomic_t usages that guard object lifetimes. > > counter_atomic* variables will wrap around to 0 when it overflows and > should not be used to guard resource lifetimes, device usage and > open counts that control state changes, and pm states. > > atomic_t variables used for pci counters keep track of pci parity and > non-parity errors. Convert them to use counter_atomic32. > > Overflow will wrap around and reset the counts as was the case prior to > the conversion. > > Signed-off-by: Shuah Khan > --- > drivers/edac/edac_pci.h | 5 +++-- > drivers/edac/edac_pci_sysfs.c | 28 ++++++++++++++-------------- > 2 files changed, 17 insertions(+), 16 deletions(-) The patches I was Cced - this one and the apei one, look ok to me. Acked-by: Borislav Petkov Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette