From: Borislav Petkov <bp@alien8.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Corey Minyard <minyard@acm.org>,
Andy Lutomirski <luto@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
Corey Minyard <cminyard@mvista.com>,
"hidehiro.kawai.ez@hitachi.com" <hidehiro.kawai.ez@hitachi.com>,
"linfeilong@huawei.com" <linfeilong@huawei.com>,
"liuzhiqiang26@huawei.com" <liuzhiqiang26@huawei.com>
Subject: Re: [PATCH v2] x86: Fix MCE error handing when kdump is enabled
Date: Thu, 1 Oct 2020 18:58:10 +0200 [thread overview]
Message-ID: <20201001165810.GF17683@zn.tnic> (raw)
In-Reply-To: <6c6238c0088747a994a2bdce38ad0242@intel.com>
On Thu, Oct 01, 2020 at 04:29:49PM +0000, Luck, Tony wrote:
> >> I was thinking about this some yesterday. It seems to me that enabling
> >> IRQS in an MCE handler is just a bad idea, but it's really a bad idea
> >> for kdump.
> >
> > I don't think this code ever thought about kdump.
>
> How useful is kdump after a machine check induced crash anyway?
>
> kdump is useful for debugging software problems. There are very
> few ways that a software bug can result in a machine check. There
> are many ways that a hardware problem can trigger a machine check
> and crash.
>
> So it would seem (statistically) that the analysis of almost every kdump
> after a machine check just says "h/w issue".
You certainly have a point.
The only use case I can think of is being able to read out the MCE
signature from the first kernel's buffer - *if* it has landed there - to
at least know what it is that caused the explosion.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-10-01 16:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 21:16 [PATCH v2] x86: Fix MCE error handing when kdump is enabled minyard
2020-09-30 17:56 ` Borislav Petkov
2020-09-30 18:49 ` Corey Minyard
2020-10-01 11:33 ` Borislav Petkov
2020-10-01 13:44 ` Corey Minyard
2020-10-01 16:16 ` Borislav Petkov
2020-10-01 16:29 ` Luck, Tony
2020-10-01 16:58 ` Borislav Petkov [this message]
2020-10-01 17:12 ` Corey Minyard
2020-10-10 1:36 ` Zhiqiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001165810.GF17683@zn.tnic \
--to=bp@alien8.de \
--cc=cminyard@mvista.com \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=linfeilong@huawei.com \
--cc=linux-edac@vger.kernel.org \
--cc=liuzhiqiang26@huawei.com \
--cc=luto@kernel.org \
--cc=minyard@acm.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox