Re: [PATCH v2] x86/mce: fix wrong no-return-ip logic in do_machine_check()

Aili Yao
2021-02-22T10:11:00Z

On Mon, 22 Feb 2021 11:03:56 +0100
Borislav Petkov <bp@alien8.de> wrote:

> On Mon, Feb 22, 2021 at 05:31:09PM +0800, Aili Yao wrote:
> > you can inject a memory UE to a VM, it should always be MCG_STATUS_RIPV 0.
>
> So the signature you injected is not something the hardware would
> generate - you just didn't set MCG_STATUS_RIPV.
>
> If so, why should the code handle invalid signatures which the harware
> cannot generate?
>

So why would intel provide this MCG_STATUS_RIPV flag, it's better to remove it as it will
never be set, and all the related logic for this flag is really needed ?