From: Carlos Bilbao <carlos.bilbao@amd.com>
To: <bp@alien8.de>
Cc: <tglx@linutronix.de>, <mingo@redhat.com>,
<dave.hansen@linux.intel.com>, <x86@kernel.org>,
<yazen.ghannam@amd.com>, <linux-kernel@vger.kernel.org>,
<linux-edac@vger.kernel.org>, <bilbao@vt.edu>,
Carlos Bilbao <carlos.bilbao@amd.com>
Subject: [PATCH v2 2/2] x86/mce: Add messages to describe panic machine errors on AMD's MCEs grading
Date: Thu, 31 Mar 2022 11:32:14 -0500 [thread overview]
Message-ID: <20220331163211.5994-3-carlos.bilbao@amd.com> (raw)
In-Reply-To: <20220331163211.5994-1-carlos.bilbao@amd.com>
When a machine error is graded as PANIC by AMD grading logic, the MCE
handler calls mce_panic(). The notification chain does not come into effect
so the AMD EDAC driver does not decode the errors. In these cases, the
messages displayed to the user are more cryptic and miss information
that might be relevant, like the context in which the error took place.
Fix the above issue including messages on AMD's grading logic for machine
errors graded as PANIC.
Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
---
arch/x86/kernel/cpu/mce/severity.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/x86/kernel/cpu/mce/severity.c b/arch/x86/kernel/cpu/mce/severity.c
index 4d52eef21230..ea4b9407bbad 100644
--- a/arch/x86/kernel/cpu/mce/severity.c
+++ b/arch/x86/kernel/cpu/mce/severity.c
@@ -307,6 +307,7 @@ static noinstr int error_context(struct mce *m, struct pt_regs *regs)
static noinstr int mce_severity_amd(struct mce *m, struct pt_regs *regs, char **msg, bool is_excp)
{
int ret;
+ char *panic_msg;
/*
* Default return value: Action required, the error must be handled
@@ -316,6 +317,7 @@ static noinstr int mce_severity_amd(struct mce *m, struct pt_regs *regs, char **
/* Processor Context Corrupt, no need to fumble too much, die! */
if (m->status & MCI_STATUS_PCC) {
+ panic_msg = "Processor Context Corrupt";
ret = MCE_PANIC_SEVERITY;
goto amd_severity;
}
@@ -339,16 +341,21 @@ static noinstr int mce_severity_amd(struct mce *m, struct pt_regs *regs, char **
if (((m->status & MCI_STATUS_OVER) && !mce_flags.overflow_recov)
|| !mce_flags.succor) {
+ panic_msg = "Uncorrected unrecoverable error";
ret = MCE_PANIC_SEVERITY;
goto amd_severity;
}
if (error_context(m, regs) == IN_KERNEL) {
+ panic_msg = "Uncorrected error in kernel context";
ret = MCE_PANIC_SEVERITY;
}
amd_severity:
+ if (msg && panic_msg)
+ *msg = panic_msg;
+
return ret;
}
--
2.31.1
next prev parent reply other threads:[~2022-03-31 16:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 16:32 [PATCH v2 0/2] x86/mce: Grade new machine errors for AMD MCEs and include messages for panic cases Carlos Bilbao
2022-03-31 16:32 ` [PATCH v2 1/2] x86/mce: Extend AMD severity grading function with new types of errors Carlos Bilbao
2022-03-31 16:32 ` Carlos Bilbao [this message]
2022-03-31 16:35 ` [PATCH v2 0/2] x86/mce: Grade new machine errors for AMD MCEs and include messages for panic cases Carlos Bilbao
-- strict thread matches above, loose matches on Subject: below --
2022-03-31 16:38 Carlos Bilbao
2022-03-31 16:38 ` [PATCH v2 2/2] x86/mce: Add messages to describe panic machine errors on AMD's MCEs grading Carlos Bilbao
2022-03-31 17:17 ` Day, Michael
2022-04-05 17:38 ` Yazen Ghannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220331163211.5994-3-carlos.bilbao@amd.com \
--to=carlos.bilbao@amd.com \
--cc=bilbao@vt.edu \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox