From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D919C4167B for ; Tue, 13 Dec 2022 17:18:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236147AbiLMRSD (ORCPT ); Tue, 13 Dec 2022 12:18:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236117AbiLMRSC (ORCPT ); Tue, 13 Dec 2022 12:18:02 -0500 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62BF520F5A for ; Tue, 13 Dec 2022 09:18:01 -0800 (PST) Received: by mail-pl1-x62f.google.com with SMTP id l10so458722plb.8 for ; Tue, 13 Dec 2022 09:18:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Bb5I9Y8wwJqoJVL/Ou+j3ICDvpki0+hAanc50qTXXeA=; b=FioCRD8KRxJEX/297VGm/pFweea/2Q0CHf9n5gl6IjwwdBBrd95Px1yVQ4QXFak46k IZ/xlVDdjWsnG9R4IZXmIKPA63HifxDo1bDOCITZI39mk2DHV2UX5jSSDb0QVHXHWeW0 7k7lytWio3RT5sVKQaZPn0F0Sv0K4/pwdI+DCr3Q7VGSOc4L83pwvPUl+GvKl+SQuJwO UHZF2AHS5J+DIr/qbSSZ3owaPQ7cI1lVZRgaZMPJXxTc1hqDOxdozkkUa1ykpFGAdKP3 KyuiME2kdWriG8Vj0I/Veln6mhGZLtlnU7v+ByHGD8zGh8tKyshaVxbMuWbdKeNGO5hW k2TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Bb5I9Y8wwJqoJVL/Ou+j3ICDvpki0+hAanc50qTXXeA=; b=BcvDyK0hURwrQcwNBXh5MTDKcwqmYRJBN0PL0TdLakoBodDzA1iZ7WCssLriPEbJi2 h4CBKeHX9LR0mMfkOBwJEF777CAdgtqOUQmcVRTIalzF4s6u+cvwW4lWTkGY/Wc9X+U+ baFPDFHpuEUxTaaamIlvp/JyNYFNbP39ovl6PZjmcqSpfu1Nfj7R7ATvdkUoNtcbCnIe jsrGPECYs0FInexacfVs40z6wsbhiiVBsdDdCFMCcMnpV/94ErnnjYOOCfNCCmaXmtOp +5nmeQKAgcSQjFSqF6QvhMMePuq6ol1U6whMDXNb0uPgVxdFTIgrNGJncW2RNLojqh1F U7ow== X-Gm-Message-State: ANoB5pkxfv22jF1ZQX61qe2SNdiNWwDX+L46qTSC9tneIYhjaEm/9Kxm XHC2gug5ZPQ9uKnKWKwOUcsU X-Google-Smtp-Source: AA0mqf4CmmkS1sGFDo6pbGxgzxTrOf+YmmXgILC1t4Aoupn3XzFTGMzrcOcJYqzwt0dxh9/FYFD04g== X-Received: by 2002:a17:903:507:b0:189:57ec:f697 with SMTP id jn7-20020a170903050700b0018957ecf697mr20190735plb.48.1670951880807; Tue, 13 Dec 2022 09:18:00 -0800 (PST) Received: from thinkpad ([27.111.75.5]) by smtp.gmail.com with ESMTPSA id l17-20020a170902d05100b00186f608c543sm99995pll.304.2022.12.13.09.17.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Dec 2022 09:17:59 -0800 (PST) Date: Tue, 13 Dec 2022 22:47:54 +0530 From: Manivannan Sadhasivam To: Krzysztof Kozlowski Cc: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, bp@alien8.de, tony.luck@intel.com, quic_saipraka@quicinc.com, konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org, quic_ppareek@quicinc.com, luca.weiss@fairphone.com, stable@vger.kernel.org Subject: Re: [PATCH v2 11/13] arm64: dts: qcom: sm6350: Remove reg-names property from LLCC node Message-ID: <20221213171754.GF4862@thinkpad> References: <20221212123311.146261-1-manivannan.sadhasivam@linaro.org> <20221212123311.146261-12-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Tue, Dec 13, 2022 at 05:31:40PM +0100, Krzysztof Kozlowski wrote: > On 12/12/2022 13:33, Manivannan Sadhasivam wrote: > > The LLCC block has several banks each with a different base address > > and holes in between. So it is not a correct approach to cover these > > banks with a single offset/size. Instead, the individual bank's base > > address needs to be specified in devicetree with the exact size. > > > > On SM6350, there is only one LLCC bank available. So only change needed is > > to remove the reg-names property from LLCC node to conform to the binding. > > > > The driver is expected to parse the reg field based on index to get the > > addresses of each LLCC banks. > > > > Cc: # 5.16 > > Fixes: ced2f0d75e13 ("arm64: dts: qcom: sm6350: Add LLCC node") > > This is a definitive no go. There is no bug here and such change cannot > be backported. > > > Reported-by: Parikshit Pareek > > What is the bug here which deserves a credit? reg-names in v5.16 were > perfectly correct. > If the driver gets backported to v5.16, it won't. But anyway, this property will stay in dts. Thanks, Mani > > Signed-off-by: Manivannan Sadhasivam > > --- > > arch/arm64/boot/dts/qcom/sm6350.dtsi | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi > > index 43324bf291c3..1f39627cd7c6 100644 > > --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi > > @@ -1174,7 +1174,6 @@ dc_noc: interconnect@9160000 { > > system-cache-controller@9200000 { > > compatible = "qcom,sm6350-llcc"; > > reg = <0 0x09200000 0 0x50000>, <0 0x09600000 0 0x50000>; > > - reg-names = "llcc_base", "llcc_broadcast_base"; > > }; > > > > gem_noc: interconnect@9680000 { > > Best regards, > Krzysztof > -- மணிவண்ணன் சதாசிவம்