From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADA1BC05027 for ; Fri, 20 Jan 2023 14:29:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229649AbjATO3U (ORCPT ); Fri, 20 Jan 2023 09:29:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229568AbjATO3T (ORCPT ); Fri, 20 Jan 2023 09:29:19 -0500 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37905233D4; Fri, 20 Jan 2023 06:28:52 -0800 (PST) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Nz1x46w9Hz688Cb; Fri, 20 Jan 2023 22:25:12 +0800 (CST) Received: from localhost (10.122.247.231) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 20 Jan 2023 14:28:16 +0000 Date: Fri, 20 Jan 2023 14:28:15 +0000 From: Jonathan Cameron To: CC: , , , Subject: Re: [RFC PATCH 1/4] rasdaemon: Move definition for BIT and BIT_ULL to a common file Message-ID: <20230120142815.00003d8b@huawei.com> In-Reply-To: <20230119171809.1406-2-shiju.jose@huawei.com> References: <20230119171809.1406-1-shiju.jose@huawei.com> <20230119171809.1406-2-shiju.jose@huawei.com> Organization: Huawei Technologies R&D (UK) Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.122.247.231] X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Thu, 19 Jan 2023 17:18:06 +0000 wrote: > From: Shiju Jose > > Move definition for BIT() and BIT_ULL() to the > common file ras-record.h > > Signed-off-by: Shiju Jose Hi Shiju, As you know I've looked at and tested this before you posted it so I'm happy with it, except mostly places where I think there is room to improve ras daemon in general ;) This patch makes sense though I suspect it will one day get moved again to an even more generic header. Reviewed-by: Jonathan Cameron Thanks Jonathan > --- > ras-non-standard-handler.h | 3 --- > ras-record.h | 3 +++ > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/ras-non-standard-handler.h b/ras-non-standard-handler.h > index 57d4cb5..393b756 100644 > --- a/ras-non-standard-handler.h > +++ b/ras-non-standard-handler.h > @@ -17,9 +17,6 @@ > #include "ras-events.h" > #include "libtrace/event-parse.h" > > -#define BIT(nr) (1UL << (nr)) > -#define BIT_ULL(nr) (1ULL << (nr)) > - > struct ras_ns_ev_decoder { > struct ras_ns_ev_decoder *next; > const char *sec_type; > diff --git a/ras-record.h b/ras-record.h > index d9f7733..219f10b 100644 > --- a/ras-record.h > +++ b/ras-record.h > @@ -25,6 +25,9 @@ > > #define ARRAY_SIZE(x) (sizeof(x)/sizeof(*(x))) > > +#define BIT(nr) (1UL << (nr)) > +#define BIT_ULL(nr) (1ULL << (nr)) > + > extern long user_hz; > > struct ras_events;