From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81C24C7EE24 for ; Tue, 6 Jun 2023 14:01:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238013AbjFFOBD (ORCPT ); Tue, 6 Jun 2023 10:01:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237745AbjFFOAp (ORCPT ); Tue, 6 Jun 2023 10:00:45 -0400 Received: from lobo.ruivo.org (lobo.ruivo.org [173.14.175.98]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C10910CC for ; Tue, 6 Jun 2023 07:00:30 -0700 (PDT) Received: by lobo.ruivo.org (Postfix, from userid 1011) id 5B2A852C9B; Tue, 6 Jun 2023 10:00:29 -0400 (EDT) Received: from jake.ruivo.org (bob.qemu.ruivo [192.168.72.19]) by lobo.ruivo.org (Postfix) with ESMTPA id 06CD15280B; Tue, 6 Jun 2023 10:00:12 -0400 (EDT) Received: by jake.ruivo.org (Postfix, from userid 1000) id E83EB220095; Tue, 6 Jun 2023 10:00:11 -0400 (EDT) Date: Tue, 6 Jun 2023 10:00:11 -0400 From: Aristeu Rozanski To: Borislav Petkov Cc: "Luck, Tony" , "linux-edac@vger.kernel.org" , Aristeu Rozanski Subject: Re: [PATCH] mce: prevent concurrent polling of MCE events Message-ID: <20230606140011.GU4090740@cathedrallabs.org> References: <20230605174104.GBZH4eMLx1cp+nQJH2@fat_crate.local> <20230605193000.GDZH43uFhBmQfSO+9D@fat_crate.local> <20230605203315.GR4090740@cathedrallabs.org> <20230605205658.GFZH5MGg2QizffZRte@fat_crate.local> <20230605210108.GS4090740@cathedrallabs.org> <20230605210610.GGZH5OQkeWMXGZzxhR@fat_crate.local> <20230605215839.GT4090740@cathedrallabs.org> <20230606082541.GAZH7thXcj7SatSNtO@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230606082541.GAZH7thXcj7SatSNtO@fat_crate.local> User-Agent: Mutt/2.2.9 (2022-11-12) Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Tue, Jun 06, 2023 at 10:25:41AM +0200, Borislav Petkov wrote: > Lemme make sure you realize what you're arguing for: you want to not log > MCE duplicates in a ring buffer which can get overwritten due to a bunch > of reasons and as such is best effort only anyway. > > Hell, it can get overwritten even by non-duplicate MCEs if they're just > enough many to overflow the buffer's size. > > So relying on dmesg for any serious error counting or whatnot is > a exercise in futility. I'm not sure when I made you believe I want to do error counting or error parsing from the kernel log. I started saying that we need to avoid, when possible, to waste kernel log. Duplicates are a waste. You mentioned not even logging MCEs at all and I said that I believe it's not right, as it might be useful to be aware of MCEs being delivered before a crash. -- Aristeu