From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60905EB64D9 for ; Tue, 27 Jun 2023 18:14:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229501AbjF0SN7 (ORCPT ); Tue, 27 Jun 2023 14:13:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231731AbjF0SNR (ORCPT ); Tue, 27 Jun 2023 14:13:17 -0400 Received: from lobo.ruivo.org (lobo.ruivo.org [173.14.175.98]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0C6E358E for ; Tue, 27 Jun 2023 11:12:46 -0700 (PDT) Received: by lobo.ruivo.org (Postfix, from userid 1011) id 0380152C78; Tue, 27 Jun 2023 14:12:39 -0400 (EDT) Received: from jake.ruivo.org (bob.qemu.ruivo [192.168.72.19]) by lobo.ruivo.org (Postfix) with ESMTPA id 963ED527BB; Tue, 27 Jun 2023 14:12:18 -0400 (EDT) Received: by jake.ruivo.org (Postfix, from userid 1000) id ACE07220032; Tue, 27 Jun 2023 14:12:17 -0400 (EDT) Date: Tue, 27 Jun 2023 14:12:17 -0400 From: Aristeu Rozanski To: Tony Luck Cc: "linux-edac@vger.kernel.org" , Borislav Petkov , "aris@redhat.com" Subject: Re: [PATCH v3] mce: prevent concurrent polling of MCE events Message-ID: <20230627181217.GA4090740@cathedrallabs.org> References: <20230627173612.GZ4090740@cathedrallabs.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Tue, Jun 27, 2023 at 11:06:48AM -0700, Tony Luck wrote: > On Tue, Jun 27, 2023 at 01:36:12PM -0400, Aristeu Rozanski wrote: > > +void intel_cmci_poll_unlock(bool locked) > > +{ > > + if (!locked) > > + return; > > + > > + spin_unlock(&cmci_poll_lock); > > +} > > This doesn't need an argument any more. The unserialize_mc_bank_access() > will only call it for the locked case. And remove checking processor's vendor on unserialize_mc_bank_access() as well. -- Aristeu