From: Atul Kumar Pant <atulpant.linux@gmail.com>
To: shubhrajyoti.datta@amd.com, sai.krishna.potthuri@amd.com,
james.morse@arm.com, mchehab@kernel.org, rric@kernel.org,
bp@alien8.de, tony.luck@intel.com, michal.simek@amd.com
Cc: Atul Kumar Pant <atulpant.linux@gmail.com>,
linux-edac@vger.kernel.org, shuah@kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: [PATCH v1] drivers: edac: zynqmp_edac: Updates return value check
Date: Sun, 6 Aug 2023 18:35:14 +0530 [thread overview]
Message-ID: <20230806130514.159102-1-atulpant.linux@gmail.com> (raw)
Updating the check of return value from edac_debugfs_create_dir
to use IS_ERR.
Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com>
---
drivers/edac/zynqmp_edac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/edac/zynqmp_edac.c b/drivers/edac/zynqmp_edac.c
index ac7d1e0b324c..cefbbafb945e 100644
--- a/drivers/edac/zynqmp_edac.c
+++ b/drivers/edac/zynqmp_edac.c
@@ -351,7 +351,7 @@ static void setup_debugfs(struct edac_device_ctl_info *edac_dev)
struct edac_priv *priv = edac_dev->pvt_info;
priv->debugfs_dir = edac_debugfs_create_dir("ocm");
- if (!priv->debugfs_dir)
+ if (IS_ERR(priv->debugfs_dir))
return;
edac_debugfs_create_x32("inject_fault_count", 0644, priv->debugfs_dir,
--
2.25.1
next reply other threads:[~2023-08-06 13:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-06 13:05 Atul Kumar Pant [this message]
2023-08-06 13:37 ` [PATCH v1] drivers: edac: zynqmp_edac: Updates return value check Greg KH
2023-08-07 2:31 ` Atul Kumar Pant
2023-08-07 6:01 ` Greg KH
2023-08-15 20:35 ` Atul Kumar Pant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230806130514.159102-1-atulpant.linux@gmail.com \
--to=atulpant.linux@gmail.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=mchehab@kernel.org \
--cc=michal.simek@amd.com \
--cc=rric@kernel.org \
--cc=sai.krishna.potthuri@amd.com \
--cc=shuah@kernel.org \
--cc=shubhrajyoti.datta@amd.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox