Re: [PATCH v11 05/37] x86/trapnr: Add event type macros to

H. Peter Anvin
2023-09-27T14:52:57Z

On September 26, 2023 1:10:51 AM PDT, Nikolay Borisov <nik.borisov@suse.com> wrote:
>
>
>On 23.09.23 г. 12:41 ч., Xin Li wrote:
>> Intel VT-x classifies events into eight different types, which is
>> inherited by FRED for event identification. As such, event type
>> becomes a common x86 concept, and should be defined in a common x86
>> header.
>>
>> Add event type macros to <asm/trapnr.h>, and use it in <asm/vmx.h>.
>>
>> Suggested-by: H. Peter Anvin (Intel) <hpa@zytor.com>
>> Tested-by: Shan Kang <shan.kang@intel.com>
>> Signed-off-by: Xin Li <xin3.li@intel.com>
>> ---
>>
>> Changes since v10:
>> * A few comment fixes and improvements (Andrew Cooper).
>> ---
>> arch/x86/include/asm/trapnr.h | 12 ++++++++++++
>> arch/x86/include/asm/vmx.h | 17 +++++++++--------
>> 2 files changed, 21 insertions(+), 8 deletions(-)
>>
>> diff --git a/arch/x86/include/asm/trapnr.h b/arch/x86/include/asm/trapnr.h
>> index f5d2325aa0b7..8d1154cdf787 100644
>> --- a/arch/x86/include/asm/trapnr.h
>> +++ b/arch/x86/include/asm/trapnr.h
>> @@ -2,6 +2,18 @@
>> #ifndef _ASM_X86_TRAPNR_H
>> #define _ASM_X86_TRAPNR_H
>> +/*
>> + * Event type codes used by FRED, Intel VT-x and AMD SVM
>> + */
>> +#define EVENT_TYPE_EXTINT 0 // External interrupt
>> +#define EVENT_TYPE_RESERVED 1
>> +#define EVENT_TYPE_NMI 2 // NMI
>> +#define EVENT_TYPE_HWEXC 3 // Hardware originated traps, exceptions
>> +#define EVENT_TYPE_SWINT 4 // INT n
>> +#define EVENT_TYPE_PRIV_SWEXC 5 // INT1
>> +#define EVENT_TYPE_SWEXC 6 // INTO, INT3
>
>nit: This turned into INTO (Oh) rather than INT0( zero) in v11
>
><nit>

INTO (letter) is correct.