RE: [PATCH v12 24/37] x86/idtentry: Incorporate definitions/declarations of the FRED entries

Li, Xin3
2023-11-28T18:39:05Z

> > FRED and IDT can share most of the definitions and declarations so
> > that in the majority of cases the actual handler implementation is the
> > same.
> >
> > The differences are the exceptions where FRED stores exception related
> > information on the stack and the sysvec implementations as FRED can
> > handle irqentry/exit() in the dispatcher instead of having it in each
> > handler.
> >
> > Also add stub defines for vectors which are not used due to Kconfig
> > decisions to spare the ifdeffery in the actual FRED dispatch code.
> >
> > Tested-by: Shan Kang <shan.kang@intel.com>
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> > Signed-off-by: Xin Li <xin3.li@intel.com>
>
> This makes me wonder too who the author is. The commit message text sounds
> like tglx. :)

You have a very good sense 😊

This is mostly from his review comments and suggestions on my original
changes to IDTENTRY. So probably I should put a "Suggested-by" instead
of "Signed-off-by" as HPA pointed out!

Thanks!
Xin