Re: [PATCH v2 3/4] mm: Change ghes code to allow poison of non-struct pfn

Jason Gunthorpe
2023-12-04T14:36:54Z

On Sun, Dec 03, 2023 at 12:23:19AM +0100, Borislav Petkov wrote:
> On Thu, Nov 23, 2023 at 06:05:11AM +0530, ankita@nvidia.com wrote:
> > - pfn = PHYS_PFN(physical_addr);
> > - if (!pfn_valid(pfn) && !arch_is_platform_page(physical_addr)) {
> > - pr_warn_ratelimited(FW_WARN GHES_PFX
> > - "Invalid address in generic error data: %#llx\n",
> > - physical_addr);
> > - return false;
> > - }
>
> You don't just remove a pfn valid test just because your weird device
> can't stomach it - you extend it, like

It wasn't removed. patch 1 moved it to memory_failure() where it makes
a lot more sense.

Jason