Re: [PATCH v2 3/4] mm: Change ghes code to allow poison of non-struct pfn

Borislav Petkov
2023-12-02T23:24:07Z

On Thu, Nov 23, 2023 at 06:05:11AM +0530, ankita@nvidia.com wrote:
> - pfn = PHYS_PFN(physical_addr);
> - if (!pfn_valid(pfn) && !arch_is_platform_page(physical_addr)) {
> - pr_warn_ratelimited(FW_WARN GHES_PFX
> - "Invalid address in generic error data: %#llx\n",
> - physical_addr);
> - return false;
> - }

You don't just remove a pfn valid test just because your weird device
can't stomach it - you extend it, like

3ad6fd77a2d6 ("x86/sgx: Add check for SGX pages to ghes_do_memory_failure()")

did, for example.

--
Regards/Gruss,
Boris.