Re: [PATCH 0/4] PCI: Consolidate TLP Log reading and printing

Bjorn Helgaas
2024-03-08T21:31:08Z

On Tue, Feb 06, 2024 at 03:57:13PM +0200, Ilpo Järvinen wrote:
> This series consolidates AER & DPC TLP Log handling code. Helpers are
> added for reading and printing the TLP Log and the format is made to
> include E-E Prefixes in both cases (previously only one DPC RP PIO
> displayed the E-E Prefixes).
>
> I'd appreciate if people familiar with ixgbe could check the error
> handling conversion within the driver is correct.
>
> Ilpo Järvinen (4):
> PCI/AER: Cleanup register variable
> PCI: Generalize TLP Header Log reading

I applied these first two to pci/aer for v6.9, thanks, these are all
nice improvements!

I postponed the ixgbe part for now because I think we should get an
ack from those maintainers or just send it to them since it subtly
changes the error and device removal checking there.

> PCI: Add TLP Prefix reading into pcie_read_tlp_log()
> PCI: Create helper to print TLP Header and Prefix Log

I'll respond to these with some minor comments.

> drivers/firmware/efi/cper.c | 4 +-
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 39 +++------
> drivers/pci/ats.c | 2 +-
> drivers/pci/pci.c | 79 +++++++++++++++++++
> drivers/pci/pci.h | 2 +-
> drivers/pci/pcie/aer.c | 28 ++-----
> drivers/pci/pcie/dpc.c | 31 ++++----
> drivers/pci/probe.c | 14 ++--
> include/linux/aer.h | 16 ++--
> include/linux/pci.h | 2 +-
> include/ras/ras_event.h | 10 +--
> include/uapi/linux/pci_regs.h | 2 +
> 12 files changed, 145 insertions(+), 84 deletions(-)
>
> --
> 2.39.2
>