Re: [PATCH 05/16] x86/amd_nb: Simplify function 4 search

Borislav Petkov
2024-10-31T11:15:39Z

On Wed, Oct 23, 2024 at 05:21:39PM +0000, Yazen Ghannam wrote:
> Use the newly added helper function to look up a CPU/Node function to
> find "function 4" devices.
>
> This avoids the need to regularly add new PCI IDs for basic discovery.
> The unique PCI IDs are still useful in case of quirks or functional
> changes. And they should be used only in such a manner.
>
> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
> ---
> arch/x86/include/asm/amd_nb.h | 1 +
> arch/x86/kernel/amd_nb.c | 66 ++---------------------------------
> 2 files changed, 4 insertions(+), 63 deletions(-)

Nice cleanup.

--
Regards/Gruss,
Boris.