Re: [PATCH 16/16] x86/amd_smn: Add support for debugfs access to SMN registers

Mario Limonciello
2024-11-05T20:53:12Z

On 11/5/2024 13:59, Borislav Petkov wrote:
> On Tue, Nov 05, 2024 at 01:56:23PM -0600, Mario Limonciello wrote:
>> OK got it. Considering that I think after this series lands we need to
>> re-open the conversation about PCI config space access to userspace;
>> particularly on regions that have been marked as exclusions.
>
> I could imagine a patch that goes and requests those regions exclusively if
> luserspace has no business poking there.
>

Take look at what pci_write_config() does today. It basically shows a
warning and taints but lets userspace proceed.

commit 278294798ac91 ("PCI: Allow drivers to request exclusive config
regions") and the matching mailing list thread linked from the commit
message have some history from it.

I'd personally like to see that taint turned into an "return -EACCES"
instead. But given the discussion linked in that commit, I think it
should be a follow up rather than part of this series.