Re: [PATCH 00/16] AMD NB and SMN rework

Bjorn Helgaas
2024-10-23T17:59:30Z

On Wed, Oct 23, 2024 at 05:21:34PM +0000, Yazen Ghannam wrote:
> Hi all,
>
> The theme of this set is decoupling the "AMD node" concept from the
> legacy northbridge support.
>
> Additionally, AMD System Management Network (SMN) access code is
> decoupled and expanded too.
>
> Patches 1-3 begin reducing the scope of AMD_NB.
>
> Patches 4-9 begin moving generic AMD node support out of AMD_NB.
>
> Patches 10-13 move SMN support out of AMD_NB and do some refactoring.
>
> Patch 14 has HSMP reuse SMN functionality.
>
> Patches 15-16 address userspace access to SMN.
>
> I say "begin" above because there is more to do here. Ultimately, AMD_NB
> should only be needed for code used on legacy systems with northbridges.
> Also, any and all SMN users in the kernel need to be updated to use the
> central SMN code. Local solutions should be avoided.

Glad to see many of the PCI device IDs going away; thanks for working
on that!

The use of pci_get_slot() and pci_get_domain_bus_and_slot() is not
ideal since all those pci_get_*() interfaces are kind of ugly in my
opinion, and using them means we have to encode topology details in
the kernel. But this still seems like a big improvement.

Bjorn