From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Borislav Petkov <bp@alien8.de>, Tony Luck <tony.luck@intel.com>,
James Morse <james.morse@arm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Richter <rric@kernel.org>,
Khuong Dinh <khuong@os.amperecomputing.com>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EDAC: Use string choice helper functions
Date: Thu, 13 Feb 2025 12:41:09 -0500 [thread overview]
Message-ID: <20250213174109.GA126857@yaz-khff2.amd.com> (raw)
In-Reply-To: <20250209215222.52260-2-thorsten.blum@linux.dev>
On Sun, Feb 09, 2025 at 10:52:21PM +0100, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_enabled_disabled(),
> str_yes_no(), str_write_read(), and str_plural() helper functions.
>
> Add a space in "All DIMMs support ECC: yes/no" to improve readability.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> drivers/edac/amd64_edac.c | 47 +++++++++++++++++++--------------------
> drivers/edac/debugfs.c | 5 ++++-
> drivers/edac/i5400_edac.c | 3 ++-
> drivers/edac/i7300_edac.c | 7 +++---
> drivers/edac/xgene_edac.c | 17 +++++++-------
> 5 files changed, 42 insertions(+), 37 deletions(-)
>
Please do include a base commit id. This patch doesn't apply to
ras/edac-for-next but does apply to mainline/master.
In any case, looks good to me.
Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>
Is there any effort to make folks aware of these helpers? Maybe an
addition to checkpatch (as a CHECK/suggestion)?
Thanks,
Yazen
next prev parent reply other threads:[~2025-02-13 17:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-09 21:52 [PATCH] EDAC: Use string choice helper functions Thorsten Blum
2025-02-10 8:20 ` Zhuo, Qiuxu
2025-02-13 17:41 ` Yazen Ghannam [this message]
2025-02-13 20:10 ` Thorsten Blum
2025-02-13 21:05 ` Yazen Ghannam
2025-02-23 21:28 ` Thorsten Blum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250213174109.GA126857@yaz-khff2.amd.com \
--to=yazen.ghannam@amd.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=khuong@os.amperecomputing.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=thorsten.blum@linux.dev \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox