Re: [PATCH v4 01/15] x86/msr: Add missing includes of

Xin Li
2025-04-30T08:42:07Z

On 4/29/2025 2:45 AM, Ilpo Järvinen wrote:
>> arch/x86/events/msr.c | 3 +++
>> arch/x86/events/perf_event.h | 1 +
>> arch/x86/events/probe.c | 2 ++
> Under arch/x86/events/ a few files seem to be missing the include?

Most C files in arch/x86/events/ include arch/x86/events/perf_event.h,
thus they don't need to include <asm/msr.h> directly once
arch/x86/events/perf_event.h includes <asm/msr.h>, and this patch does
that.

The following files include arch/x86/events/intel/uncore.h which
includes arch/x86/events/perf_event.h, thus no change needed:
arch/x86/events/intel/uncore.c
arch/x86/events/intel/uncore_discovery.c
arch/x86/events/intel/uncore_nhmex.c
arch/x86/events/intel/uncore_snb.c
arch/x86/events/intel/uncore_snbep.c

The following 2 files don't include arch/x86/events/perf_event.h so they
include <asm/msr.h> directly with this patch:
arch/x86/events/msr.c
arch/x86/events/probe.c

arch/x86/events/amd/uncore.c doesn't include
arch/x86/events/perf_event.h but includes <asm/msr.h> already.

So we are good in this directory, but it should be a separate patch with
the above explanation then.