RE: [PATCH RESEND V2 1/2] x86/mce: Fix missing address mask in recovery for errors in TDX/SEAM non-root mode

Luck, Tony
2025-08-20T16:12:32Z

> >> For struct mce? Maybe that should be 2 new fields:
> >>
> >> __u64 addr; /* Deprecated */
> >> ...
> >> __u64 mci_addr; /* Bank's MCi_ADDR MSR */
> >> __u64 phys_addr; /* Physical address */
> >
> > Would "addr" keep the current (low bits masked, high bits preserved) value?
>
> Yeah, it wouldn't make much sense if phys_addr was the same as addr anyway.
> Not really thinking

The other option (but a bad one) would be:

__u64 deprecated; /* was "addr" */
...
__u64 mci_addr; /* Bank's MCi_ADDR MSR */
__u64 phys_addr; /* Physical address */

which would be good to force cleanup in the kernel, but bad for preserving
ABI (since "struct mce" is visible to user space via /dev/mcelog).

-Tony