[PATCH 4/4] EDAC/mc_sysfs: Begin deprecating legacy sysfs EDAC interface

Avadhut Naik
2025-10-13T17:37:38Z

The legacy sysfs EDAC interface has been made obsolete more than a decade
ago through the introduction of a new per-DIMM interface.

The legacy interface however, hasn't been removed till date.

Begin deprecating it so that it can eventually be removed by v6.21.

Signed-off-by: Avadhut Naik <avadhut.naik@amd.com>
---
drivers/edac/Kconfig | 2 +-
drivers/edac/edac_mc.h | 5 +++++
drivers/edac/edac_mc_sysfs.c | 16 ++++++++++++++++
3 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
index 39352b9b7a7e..fdfeba848114 100644
--- a/drivers/edac/Kconfig
+++ b/drivers/edac/Kconfig
@@ -25,7 +25,7 @@ if EDAC

config EDAC_LEGACY_SYSFS
bool "EDAC legacy sysfs"
- default y
+ default n
help
Enable the compatibility sysfs nodes.
Use 'Y' if your edac utilities aren't ported to work with the newer
diff --git a/drivers/edac/edac_mc.h b/drivers/edac/edac_mc.h
index 881b00eadf7a..78b49d6906fd 100644
--- a/drivers/edac/edac_mc.h
+++ b/drivers/edac/edac_mc.h
@@ -95,6 +95,11 @@ do { \

#define to_mci(k) container_of(k, struct mem_ctl_info, dev)

+static inline void deprecate_interface(void)
+{
+ pr_warn_once("NOTICE: The legacy EDAC sysfs interface has been deprecated and will be removed by v6.21. Please switch to the new interface!\n");
+}
+
/**
* edac_mc_alloc() - Allocate and partially fill a struct &mem_ctl_info.
*
diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c
index 8689631f1905..8ed4b239b7f1 100644
--- a/drivers/edac/edac_mc_sysfs.c
+++ b/drivers/edac/edac_mc_sysfs.c
@@ -144,6 +144,8 @@ struct dev_ch_attribute {
static ssize_t csrow_ue_count_show(struct device *dev,
struct device_attribute *mattr, char *data)
{
+ deprecate_interface();
+
struct csrow_info *csrow = to_csrow(dev);

return sysfs_emit(data, "%u\n", csrow->ue_count);
@@ -152,6 +154,8 @@ static ssize_t csrow_ue_count_show(struct device *dev,
static ssize_t csrow_ce_count_show(struct device *dev,
struct device_attribute *mattr, char *data)
{
+ deprecate_interface();
+
struct csrow_info *csrow = to_csrow(dev);

return sysfs_emit(data, "%u\n", csrow->ce_count);
@@ -160,6 +164,8 @@ static ssize_t csrow_ce_count_show(struct device *dev,
static ssize_t csrow_size_show(struct device *dev,
struct device_attribute *mattr, char *data)
{
+ deprecate_interface();
+
struct csrow_info *csrow = to_csrow(dev);
int i;
u32 nr_pages = 0;
@@ -172,6 +178,8 @@ static ssize_t csrow_size_show(struct device *dev,
static ssize_t csrow_mem_type_show(struct device *dev,
struct device_attribute *mattr, char *data)
{
+ deprecate_interface();
+
struct csrow_info *csrow = to_csrow(dev);

return sysfs_emit(data, "%s\n", edac_mem_types[csrow->channels[0]->dimm->mtype]);
@@ -180,6 +188,8 @@ static ssize_t csrow_mem_type_show(struct device *dev,
static ssize_t csrow_dev_type_show(struct device *dev,
struct device_attribute *mattr, char *data)
{
+ deprecate_interface();
+
struct csrow_info *csrow = to_csrow(dev);

return sysfs_emit(data, "%s\n", dev_types[csrow->channels[0]->dimm->dtype]);
@@ -189,6 +199,8 @@ static ssize_t csrow_edac_mode_show(struct device *dev,
struct device_attribute *mattr,
char *data)
{
+ deprecate_interface();
+
struct csrow_info *csrow = to_csrow(dev);

return sysfs_emit(data, "%s\n", edac_caps[csrow->channels[0]->dimm->edac_mode]);
@@ -199,6 +211,8 @@ static ssize_t channel_dimm_label_show(struct device *dev,
struct device_attribute *mattr,
char *data)
{
+ deprecate_interface();
+
struct csrow_info *csrow = to_csrow(dev);
unsigned int chan = to_channel(mattr);
struct rank_info *rank = csrow->channels[chan];
@@ -238,6 +252,8 @@ static ssize_t channel_dimm_label_store(struct device *dev,
static ssize_t channel_ce_count_show(struct device *dev,
struct device_attribute *mattr, char *data)
{
+ deprecate_interface();
+
struct csrow_info *csrow = to_csrow(dev);
unsigned int chan = to_channel(mattr);
struct rank_info *rank = csrow->channels[chan];
--
2.43.0