From: Bjorn Helgaas <helgaas@kernel.org>
To: Shuai Xue <xueshuai@linux.alibaba.com>
Cc: rostedt@goodmis.org, lukas@wunner.de, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
ilpo.jarvinen@linux.intel.com, mattc@purestorage.com,
Jonathan.Cameron@huawei.com, alok.a.tiwari@oracle.com,
bhelgaas@google.com, tony.luck@intel.com, bp@alien8.de,
mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
oleg@redhat.com, naveen@kernel.org, davem@davemloft.net,
anil.s.keshavamurthy@intel.com, mark.rutland@arm.com,
peterz@infradead.org, tianruidong@linux.alibaba.com
Subject: Re: [PATCH v14 0/3] PCI: trace: Add a RAS tracepoint to monitor link speed changes
Date: Wed, 10 Dec 2025 18:30:57 -0600 [thread overview]
Message-ID: <20251211003057.GA3553594@bhelgaas> (raw)
In-Reply-To: <20251210132907.58799-1-xueshuai@linux.alibaba.com>
On Wed, Dec 10, 2025 at 09:29:04PM +0800, Shuai Xue wrote:
> changes since v13:
> - fix doc typos per ALOK TIWARI
>
> changes since v12:
> - add Reviewed-by tag for PATCH 1 from Steve
> - add Reviewed-by tag for PATCH 1-3 from Ilpo
> - add comments for why use string to define tracepoint per Steve
> - minor doc improvements from Ilpo
> - remove use pci_speed_string to fix PCI dependends which cause build error on sparc64
>
> changes since v11:
> - rebase to Linux 6.18-rc1 (no functional changes)
>
> changes since v10:
> - explicitly include header file per Ilpo
> - add comma on any non-terminator entry per Ilpo
> - compile trace.o under CONFIG_TRACING per Ilpo
>
> changes since v9:
> - add a documentation about PCI tracepoints per Bjorn
> - create a dedicated drivers/pci/trace.c that always defines the PCI tracepoints per Steve
> - move tracepoint callite into __pcie_update_link_speed() per Lukas and Bjorn
>
> changes since v8:
> - rewrite commit log from Bjorn
> - move pci_hp_event to a common place (include/trace/events/pci.h) per Ilpo
> - rename hotplug event strings per Bjorn and Lukas
> - add PCIe link tracepoint per Bjorn, Lukas, and Ilpo
>
> changes since v7:
> - replace the TRACE_INCLUDE_PATH to avoid macro conflict per Steven
> - pick up Reviewed-by from Lukas Wunner
>
> Hotplug events are critical indicators for analyzing hardware health, and
> surprise link downs can significantly impact system performance and reliability.
> In addition, PCIe link speed degradation directly impacts system performance and
> often indicates hardware issues such as faulty devices, physical layer problems,
> or configuration errors.
>
> This patch set add PCI hotplug and PCIe link tracepoint to help analyze PCI
> hotplug events and PCIe link speed degradation.
>
> Shuai Xue (3):
> PCI: trace: Add a generic RAS tracepoint for hotplug event
> PCI: trace: Add a RAS tracepoint to monitor link speed changes
> Documentation: tracing: Add documentation about PCI tracepoints
>
> Documentation/trace/events-pci.rst | 74 +++++++++++++++++
> drivers/pci/Makefile | 3 +
> drivers/pci/hotplug/pciehp_ctrl.c | 31 +++++--
> drivers/pci/hotplug/pciehp_hpc.c | 3 +-
> drivers/pci/pci.c | 2 +-
> drivers/pci/pci.h | 21 ++++-
> drivers/pci/pcie/bwctrl.c | 4 +-
> drivers/pci/probe.c | 9 +-
> drivers/pci/trace.c | 11 +++
> include/trace/events/pci.h | 129 +++++++++++++++++++++++++++++
> include/uapi/linux/pci.h | 7 ++
> 11 files changed, 279 insertions(+), 15 deletions(-)
> create mode 100644 Documentation/trace/events-pci.rst
> create mode 100644 drivers/pci/trace.c
> create mode 100644 include/trace/events/pci.h
Applied to pci/trace for v6.20, thanks! This will be rebased after
v6.19-rc1.
prev parent reply other threads:[~2025-12-11 0:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 13:29 [PATCH v14 0/3] PCI: trace: Add a RAS tracepoint to monitor link speed changes Shuai Xue
2025-12-10 13:29 ` [PATCH v14 1/3] PCI: trace: Add a generic RAS tracepoint for hotplug event Shuai Xue
2025-12-10 13:29 ` [PATCH v14 2/3] PCI: trace: Add a RAS tracepoint to monitor link speed changes Shuai Xue
2025-12-10 13:29 ` [PATCH v14 3/3] Documentation: tracing: Add documentation about PCI tracepoints Shuai Xue
2025-12-11 0:30 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251211003057.GA3553594@bhelgaas \
--to=helgaas@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=alok.a.tiwari@oracle.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mattc@purestorage.com \
--cc=mhiramat@kernel.org \
--cc=naveen@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tianruidong@linux.alibaba.com \
--cc=tony.luck@intel.com \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox