public inbox for linux-edac@vger.kernel.org
 help / color / mirror / Atom feed
From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Nick Bowler <nbowler@draconx.ca>
Cc: Borislav Petkov <bp@alien8.de>,
	linux-kernel@vger.kernel.org, regressions@lists.linux.dev,
	x86@kernel.org, linux-edac@vger.kernel.org
Subject: Re: PROBLEM: boot hang on ASUS P2B-F (regression)
Date: Mon, 6 Apr 2026 09:22:34 -0400	[thread overview]
Message-ID: <20260406132234.GA327112@yaz-khff2.amd.com> (raw)
In-Reply-To: <2fgbldvzh3fahs5vipak33alxbn552otazldu6ftamr6reii4t@6syhuc665vys>

On Sun, Mar 22, 2026 at 11:10:45AM -0400, Nick Bowler wrote:
> On Sat, Mar 21, 2026 at 10:52:24PM +0100, Borislav Petkov wrote:
> > Anyway, since you're partially reverting, can you pls try reverting the
> > Intel-relevant hunks and narrow it down, if possible.
> >
> > From the looks of it, I'm thinking:
> > 
> > * comment out the intel_apply_cpu_quirks() call
> > 
> > * comment out this hunk
> > 
> >         /*
> >          * There are also broken BIOSes on some Pentium M and
> >          * earlier systems:
> >          */
> >         if (c->x86_vfm < INTEL_CORE_YONAH && mca_cfg.bootlog < 0)
> >                 mca_cfg.bootlog = 0;
> 
> Making these changes does not appear to have any effect.
> 
> I whittled down the revert to the following patch, and this is
> sufficient to get the machine booting again:
> 
> diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
> index 8dd424ac5de8..83eb037d4d46 100644
> --- a/arch/x86/kernel/cpu/mce/core.c
> +++ b/arch/x86/kernel/cpu/mce/core.c
> @@ -2284,6 +2284,12 @@ void mcheck_cpu_init(struct cpuinfo_x86 *c)
>  
>  	__mcheck_cpu_cap_init();
>  
> +	{
> +	struct mce_bank *mce_banks = this_cpu_ptr(mce_banks_array);
> +	if (c->x86_vfm < INTEL_NEHALEM_EP && this_cpu_read(mce_num_banks))
> +		mce_banks[0].init = false;
> +	}
> +

Hi Nick,

Can you please test after enabling CONFIG_X86_MCE_INTEL?

Without this, the Intel-specific code, including this quirk, will not be
built.

Thanks,
Yazen

      reply	other threads:[~2026-04-06 13:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-21 20:26 PROBLEM: boot hang on ASUS P2B-F (regression) Nick Bowler
2026-03-21 20:43 ` Borislav Petkov
2026-03-21 21:00   ` Nick Bowler
2026-03-21 21:52     ` Borislav Petkov
2026-03-22 15:10       ` Nick Bowler
2026-04-06 13:22         ` Yazen Ghannam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260406132234.GA327112@yaz-khff2.amd.com \
    --to=yazen.ghannam@amd.com \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nbowler@draconx.ca \
    --cc=regressions@lists.linux.dev \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox