From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8392C429811 for ; Tue, 5 May 2026 12:25:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777983908; cv=none; b=BtyFMEELqxIaOnTulXVpJpVpuPaGMlFDBKbIjp7CmCQP5Gxo6v5ojbD+me25fjozmQ7Gs5/ke8yRepsPPMn7DgG5xUj3mAJd7i8ar4G13lEjRc6uOkvRDWEUbnjRgABlAeM/3gaD5KHSDQ1xXTg2cCOERJsJbxTVqAx6PuOiQVk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777983908; c=relaxed/simple; bh=K7/WGQ524x+e2ze3I8r02DnkbU84gUgAARamEEr7Lg4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZOodjsNtRq+HRpycqRT/cXWdSN9CZFeatHVuxeyu7hUi+F2KrJnCSYnwVy40JzDodFtHE9deiYF8L4BoeJ7ZwBZHwZ8utH3itl8iCcCbtMnNX5Tm9NHmhU+EmuJ0xwOOW4tWWP5f2VrA/7HdTJW4hfdzi0nATk/dJRV+ANCnzyE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JOddLap0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iV0tTTBc; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JOddLap0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iV0tTTBc" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6456HH3v331125 for ; Tue, 5 May 2026 12:25:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Pmyq3Jn3jS95x5qGd6vMxoixGm9Dq9F0RVe09Iz/Q7E=; b=JOddLap0jB/q49ce ysA9hU1v8gpGvceX4so5na3MuDovcsC1hapvbgPTLjG4p90D0Lw7HNcngXZ8/o6f tS+tfHIjWHQtBoTPOdn8KqC2FBKhiH7v1k89tJR807w/wDuW/t1OsV3tRpzXaiyp hWa7nKC5Wp9z/EmyBWE+gvt1HrVrRrEqpn/6Hv1Z83Sk5Rrg+vZqPAVwaeLYFkEi VHpzE4WWdDmo6ck89/7+uXZ2KXkHvg4UmYyS6Jvm6b1glK6VTNFgfPYzybMqouAZ 2MLbCJq0Zp8irK6UA9PL27jDvN5MpXHR2XrdRxkSh+NgPIq5TRwHZOdA2kdSu72p aYK6Ug== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dxvr1cdhb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 05 May 2026 12:25:05 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-b633babe5b9so300206a12.3 for ; Tue, 05 May 2026 05:25:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777983905; x=1778588705; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Pmyq3Jn3jS95x5qGd6vMxoixGm9Dq9F0RVe09Iz/Q7E=; b=iV0tTTBclAELqgIkx4OmeTTTwtI6shm8Z/kvYiOkg9o+QLk1po69gtRjjYkOth31iv Uk7Yi9y7Lclt/Ssaf7kpIgZaFWS+/jV1RntMrhSrMLVT7Mc5xQHOGr6Bu1XIcp0QBdh8 8sWQaAAWHdaxOUeoEcvxSp/EbfSGGvcPWiBT1oQrRGgKLyaDQbW53BF57uYI7JyiAotz cB+lOenVTHqMpEbWBKmSPFCdnU5yFIe+ivrvWstKnpa6E5+73lDUFZW4UT8gzKokVolO XxlE89okldt6eD9AhDTNSmdVAxj3O6DONsRdTg8M/pdkRmCoUHpwEq/Enqwe1a1u1B7Y YQGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777983905; x=1778588705; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Pmyq3Jn3jS95x5qGd6vMxoixGm9Dq9F0RVe09Iz/Q7E=; b=hD16ZdGu0cxxB6n3g25smuAG5rTrcxTyyP14lKW7sWspUjfaMZ7NJHQlRLv2yhj68g 3URBOwyDh5L48L1wB/7fQ+IcS0huZdnNFvZG1Sj/ie8IGIVyJAlbFlQFCH1CBopFycW4 tRKMFSx7hbKSHzHSkoWAW9387GstTRLiawIvsIVrCMWzX7I+NJPql2OpfL5yUCUiqqUO nf85ekXOwr/Cf8JVLRM+VXTTMizNN+P5JhoApVdyF7aSl2WlxVIGZhZGWYkKvoG6uM7r p/zilSowNsAm4Bwr+g6I08r/xWB0HQrXwRLCzswnZOlc9PcAILY+86dop6BAOswZD3PJ YADg== X-Forwarded-Encrypted: i=1; AFNElJ/t2etpZc2PrUvB7/kMnqoUUn1dt+250SAR7KWBx8ngAXr2NQ+VtId2IWys/v5ZBYgrHpTq1gFXZY85@vger.kernel.org X-Gm-Message-State: AOJu0YwMlbrtRQeK8zgYSld9G112PGq1kjcokwXWWUOKGE76x9MM417V LkPStd4uf7ZWqOC4fkhSVo2A2HBZAoanuBHqeDSd54c/+B7TEOj1PKeOd9zJxNWgC8j0U9hjZeK A4ayjO+Q695Cwk1KKWNdZEXoGZ9TRJMH9BeBP0UhvqJoXRaeD2L4NIlHZCO/cp/oN X-Gm-Gg: AeBDieta7ZSLcj5YVfpdDYHzdY0v41zhl+Ara96Cr8BCehIUmFC1nUSM2Wsq4MmRIIj TnIzYIiOuicfB+uG2+nhucAS6ejc74wUYDekN9drl+r9jDuJdYG7kwx/7RmIx6z5aQWYeBGGKud nUZoJOdwWYzEpj4y1UZN+4d5yGd2dCD9tPPjKWQKRbAuKoo2Y2+4GQuNRgAqNzoJMKO0jabk4Ia I7r+WqFZ/znODQ2RIJymwgNLjDhvvyg09y8gt9xIwCS+HmEq3uxJOKi9SsHlxD6zFwDWBdSEA85 poqopYBUdbAXsxjxhSlAfn67o3TVp2rc+m0M5mzqqy8ZIcZ9D78GO8Ac70sVMs2b5Yc9M/hCIpG oMm37jHRsJ/OTXWwfLKoYzh/mkexlV0K8joYhz+YXW25o2aGxACxHhP19i3ZUxV4= X-Received: by 2002:a05:6a21:6906:b0:39b:91d1:6c10 with SMTP id adf61e73a8af0-3aa3e94ebb9mr1574700637.4.1777983905063; Tue, 05 May 2026 05:25:05 -0700 (PDT) X-Received: by 2002:a05:6a21:6906:b0:39b:91d1:6c10 with SMTP id adf61e73a8af0-3aa3e94ebb9mr1574672637.4.1777983904596; Tue, 05 May 2026 05:25:04 -0700 (PDT) Received: from hu-uchheda-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7ffbbaac5bsm12597998a12.6.2026.05.05.05.24.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 05:25:04 -0700 (PDT) From: Umang Chheda Date: Tue, 05 May 2026 17:53:46 +0530 Subject: [PATCH 2/8] ras: aest: Fix CE/UE error counts not incrementing in debugfs Precedence: bulk X-Mailing-List: linux-edac@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260505-aest-devicetree-support-v1-2-d5d6ffacf0a5@oss.qualcomm.com> References: <20260505-aest-devicetree-support-v1-0-d5d6ffacf0a5@oss.qualcomm.com> In-Reply-To: <20260505-aest-devicetree-support-v1-0-d5d6ffacf0a5@oss.qualcomm.com> To: Ruidong Tian , Tony Luck , Borislav Petkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , catalin.marinas@arm.com, will@kernel.org, lpieralisi@kernel.org, rafael@kernel.org, mark.rutland@arm.com, Sudeep Holla Cc: linux-arm-msm@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-edac@vger.kernel.org, Umang Chheda X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777983885; l=2690; i=umang.chheda@oss.qualcomm.com; s=20260328; h=from:subject:message-id; bh=K7/WGQ524x+e2ze3I8r02DnkbU84gUgAARamEEr7Lg4=; b=5srgoRDiOLE+04KITceVdE78eHY9ax0xzcodvWQFYmfY3QszjcUqV1fapWymL8cEoMNtESzDE hlR4muq4F70BQ11YJzNFbjlpe+vvXZxKIK3RDMz5XqD1b9rqRIt0Cm1 X-Developer-Key: i=umang.chheda@oss.qualcomm.com; a=ed25519; pk=3+tjZ+PFFYphz0Vvu4B14pBQSzqcG0jZAQspTaDRQYA= X-Proofpoint-ORIG-GUID: REaxOfx73Hg2D-Ucd_ZN1Ya9nTh1PrOR X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA1MDExNyBTYWx0ZWRfX2cwDM4HK7/Ei iDLMWzgj+Yk+RzrvSbjwB5o+As9CbXypSul2MSGcOvlkLnLq2s/IHS9TsKFI9tYWA9VXq6zWkqG 11Cv6sYs6Z0GTdtZz8AYTF00vI84OOoAGpqatnOaPdK4LQAj1NJLyufPhQY6EExYp7HCzDVt/vp MfOSDx2c2SPJBmI30TOM8o0wjUKsSMqRqtP+ObifmYjmpS712mRnaUwhgze3WCoqww3efaEhpsZ pyDYjm+LRmJOHTVv4tYrVtXnMAPwLa+/C5swtCb226e2thG96ENSOeBPvcFa7oTVdkA1ZIbXYj7 aAfHf8qHqll8YIxGpYiVdBHVbSWZGaSvTmbcHM//vN6X3a+4BC3pQzGFr1VGQ0ZWBuGNCuDccTk EoNfuGQH+sge3wptUQWaoiyCaAd4vaJWsooSYB+BSrjv9B8SAHMfJTrE8gdzX1bV/msRjzZanhB kcuAg/lvHbA2RV25IeA== X-Proofpoint-GUID: REaxOfx73Hg2D-Ucd_ZN1Ya9nTh1PrOR X-Authority-Analysis: v=2.4 cv=RvL16imK c=1 sm=1 tr=0 ts=69f9e1a1 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=IvwcuExtd9bf9WbcJAsA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-05_02,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605050117 The error counts visible under: /sys/kernel/debug/aest//processor//err_count always reported zero, even though corrected errors (CEs) were being serviced by the interrupt handler. aest_oncore_dev_init_debugfs() sets up per CPU debugfs entries but wired them up incorrectly in two places: - this_cpu_ptr(adev->adev_oncore) was used inside for_each_possible_cpu(). This always selects the slot for the CPU executing the init code, so all debugfs files ended up referencing the same per CPU aest_device instance instead of the CPU indicated by the loop variable. - The code referenced adev->nodes[i], i.e. the template nodes allocated before __setup_ppi, rather than the per-CPU copies at percpu_dev->nodes[i]. The IRQ handler updates CE counters in the per-CPU records created by __setup_ppi, the template records are never touched at runtime, so err_count always read as zero. Fix this by: - Using per_cpu_ptr(adev->adev_oncore, cpu) when iterating over CPUs. Wiring debugfs files to percpu_dev->nodes[i] so counters reflect the data updated by the IRQ handler. - Using adev->nodes[i].name for debugfs directory names. The per-CPU node receives name via a shallow memcpy and is not the authoritative source. Signed-off-by: Umang Chheda --- drivers/ras/aest/aest-sysfs.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/ras/aest/aest-sysfs.c b/drivers/ras/aest/aest-sysfs.c index 66e9c1103f99..f710503e4d74 100644 --- a/drivers/ras/aest/aest-sysfs.c +++ b/drivers/ras/aest/aest-sysfs.c @@ -189,16 +189,23 @@ aest_oncore_dev_init_debugfs(struct aest_device *adev) char name[16]; for_each_possible_cpu(cpu) { - percpu_dev = this_cpu_ptr(adev->adev_oncore); + percpu_dev = per_cpu_ptr(adev->adev_oncore, cpu); - snprintf(name, sizeof(name), "processor%u%u", cpu); + snprintf(name, sizeof(name), "processor%u", cpu); percpu_dev->debugfs = debugfs_create_dir(name, adev->debugfs); for (i = 0; i < adev->node_cnt; i++) { - node = &adev->nodes[i]; - - node->debugfs = debugfs_create_dir(node->name, - percpu_dev->debugfs); + node = &percpu_dev->nodes[i]; + + /* + * Use adev->nodes[i].name (the original) rather than + * node->name from the per-CPU copy. The per-CPU copy + * receives node->name via shallow memcpy in __setup_ppi; + * the original is the authoritative, guaranteed-valid + * string. + */ + node->debugfs = debugfs_create_dir(adev->nodes[i].name, + percpu_dev->debugfs); aest_node_init_debugfs(node); } } -- 2.34.1