From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@mailo.com>,
"Michael Roth" <michael.roth@amd.com>,
"Eric Blake" <eblake@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
linux-edac@vger.kernel.org, "John Snow" <jsnow@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Mauro Carvalho Chehab" <mchehab+huawei@kernel.org>,
"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Ani Sinha" <anisinha@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>
Subject: [PATCH v4 09/13] qapi/parser: add mea culpa comment for ensure_returns
Date: Thu, 11 Jun 2026 00:23:28 -0400 [thread overview]
Message-ID: <20260611042332.482979-10-jsnow@redhat.com> (raw)
In-Reply-To: <20260611042332.482979-1-jsnow@redhat.com>
These algorithms are quite a mess currently, but they are temporary
until we add the inliner which will address these issues more
holistically. For now, add the "mea culpa".
Signed-off-by: John Snow <jsnow@redhat.com>
---
scripts/qapi/parser.py | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py
index 261f8ba9f8b..b0cead38b1f 100644
--- a/scripts/qapi/parser.py
+++ b/scripts/qapi/parser.py
@@ -866,6 +866,13 @@ def connect_feature(self, feature: 'QAPISchemaFeature') -> None:
self._features[feature.name].connect(feature)
def ensure_returns(self, info: QAPISourceInfo) -> None:
+ # This is more complicated than it ought to be. The doc
+ # parser should already know where a generated RETURNS section
+ # should go. It currently doesn't, mostly because it accepts
+ # tagged sections in any order.
+ #
+ # TODO: Tighten doc syntax and simplify.
+
if any(s.kind == QAPIDoc.Kind.RETURNS for s in self.all_sections):
return
--
2.54.0
next prev parent reply other threads:[~2026-06-11 4:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 4:23 [PATCH v4 00/13] qapi: add formal "intro" section John Snow
2026-06-11 4:23 ` [PATCH v4 01/13] python: temporarily restrict max mypy version John Snow
2026-06-11 4:23 ` [PATCH v4 02/13] tests/qapi: generate output in source order John Snow
2026-06-11 4:23 ` [PATCH v4 03/13] qapi/docs: remove unused QAPIDoc subsection members John Snow
2026-06-11 4:23 ` [PATCH v4 04/13] qapi/docs: add has_features property John Snow
2026-06-11 4:23 ` [PATCH v4 05/13] qapi/docs: make remaining subsection members "private" John Snow
2026-06-11 4:23 ` [PATCH v4 06/13] qapi/docs: fix comment phrasing John Snow
2026-06-11 4:23 ` [PATCH v4 07/13] qapi/docs: add "Intro" section John Snow
2026-06-11 4:23 ` [PATCH v4 08/13] qapi/parser: move _insert_near_kind() method John Snow
2026-06-11 4:23 ` John Snow [this message]
2026-06-11 4:23 ` [PATCH v4 10/13] qapi/docs: adjust stub member insertion algorithm John Snow
2026-06-11 4:23 ` [PATCH v4 11/13] qapi/docs: remove implicit Plain section John Snow
2026-06-11 4:23 ` [PATCH v4 12/13] qapi/docs: add rendering for INTRO sections John Snow
2026-06-11 4:23 ` [PATCH v4 13/13] qapi/docs: add "Intro" section parsing John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260611042332.482979-10-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=anisinha@redhat.com \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=eblake@redhat.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=linux-edac@vger.kernel.org \
--cc=marcandre.lureau@redhat.com \
--cc=mchehab+huawei@kernel.org \
--cc=michael.roth@amd.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=philmd@mailo.com \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox