From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Borislav Petkov <bp@kernel.org>
Cc: linux-edac <linux-edac@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Borislav Petkov (AMD)" <bp@alien8.de>
Subject: Re: [PATCH] EDAC/mce_amd: Do not print a stray newline
Date: Mon, 13 Jul 2026 14:44:02 -0400 [thread overview]
Message-ID: <20260713184402.GA364094@yaz-khff2.amd.com> (raw)
In-Reply-To: <20260712031648.486110-1-bp@kernel.org>
On Sat, Jul 11, 2026 at 08:16:48PM -0700, Borislav Petkov wrote:
> From: "Borislav Petkov (AMD)" <bp@alien8.de>
>
> With error records which don't have FRU text, an empty newline is
> printed like this:
>
> [28014.094610] mce: [Hardware Error]: Machine check events logged
> [28014.094674] [Hardware Error]: Corrected error, no action required.
> [28014.094687] [Hardware Error]: CPU:11 (19:44:1) MC0_STATUS[-|CE|MiscV|AddrV|-|-|SyndV|CECC|-|-|-]: 0x9c20400001010135
> [28014.094724] [Hardware Error]: Error Addr: 0x000000019ba9a974
> [28014.094732] [Hardware Error]: IPID: 0x001000b000000000, Syndrome: 0x000000081a1f2505
>
> [28014.094744] [Hardware Error]: Load Store Unit Ext. Error Code: 1
> [28014.094748] [Hardware Error]: cache level: L1, tx: DATA, mem-tx: DRD
>
> Move the \n into the last printk() call where it belongs.
>
> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>
Thanks,
Yazen
next prev parent reply other threads:[~2026-07-13 18:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-12 3:16 [PATCH] EDAC/mce_amd: Do not print a stray newline Borislav Petkov
2026-07-13 18:44 ` Yazen Ghannam [this message]
2026-07-13 23:22 ` Borislav Petkov
2026-07-14 10:28 ` Srivatsa S. Bhat
2026-07-14 13:04 ` Yazen Ghannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260713184402.GA364094@yaz-khff2.amd.com \
--to=yazen.ghannam@amd.com \
--cc=bp@alien8.de \
--cc=bp@kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox