Linux EDAC development
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@kernel.org>
To: bp@alien8.de, tony.luck@intel.com
Cc: dinguyen@kernel.org, rounakdas2025@gmail.com,
	niravkumar.l.rabara@altera.com, linux-edac@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: [PATCH 03/10] EDAC/altera: Guard against NULL match data in altr_sdram_probe()
Date: Mon, 27 Jul 2026 08:24:09 -0500	[thread overview]
Message-ID: <20260727132416.807230-4-dinguyen@kernel.org> (raw)
In-Reply-To: <20260727132416.807230-1-dinguyen@kernel.org>

sashiko reports: If a device is manually bound and lacks a valid match entry,
of_match_node() or device_get_match_data() could return NULL.

altr_sdram_probe() dereferenced the pointer returned by of_match_node()
and device_get_match_data() without checking it, which could cause a NULL
pointer dereference when no match data is found. Add a guard that logs
an error and returns -ENODEV.

Assisted-by: Cursor:claude-4.8-opus
Fixes: 143f4a5ac5af ("EDAC, altera: Refactor for Altera CycloneV SoC")
Cc: stable@vger.kernel.org
Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
---
 drivers/edac/altera_edac.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
index 34b33298cf86e..8cbf71ce5d2d8 100644
--- a/drivers/edac/altera_edac.c
+++ b/drivers/edac/altera_edac.c
@@ -300,6 +300,10 @@ static int altr_sdram_probe(struct platform_device *pdev)
 
 	/* Check specific dependencies for the module */
 	priv = device_get_match_data(&pdev->dev);
+	if (!priv) {
+		edac_printk(KERN_ERR, EDAC_MC, "No match data found\n");
+		return -ENODEV;
+	}
 
 	/* Validate the SDRAM controller has ECC enabled */
 	if (regmap_read(mc_vbase, priv->ecc_ctrl_offset, &read_reg) ||
-- 
2.42.0.411.g813d9a9188


  parent reply	other threads:[~2026-07-27 13:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27 13:24 [PATCH 00/10] EDAC/altera: Address sashiko reviews part 1 Dinh Nguyen
2026-07-27 13:24 ` [PATCH 01/10] EDAC/altera: Fix NULL of_node dereference altr_edac_device_probe() Dinh Nguyen
2026-07-27 13:24 ` [PATCH 02/10] EDAC/altera: Fix use-after-free in error paths Dinh Nguyen
2026-07-27 13:24 ` Dinh Nguyen [this message]
2026-07-27 13:24 ` [PATCH 04/10] EDAC/altera: Fix IRQ domain leak on platform_get_irq() failure Dinh Nguyen
2026-07-27 13:24 ` [PATCH 05/10] EDAC/altera: Fix code leak on dci allocation failure Dinh Nguyen
2026-07-27 13:24 ` [PATCH 06/10] EDAC/altera: Add suppress_bind_attrs so driver cannot get unbound Dinh Nguyen
2026-07-27 13:24 ` [PATCH 07/10] EDAC/altera: Drop __init from ECC setup paths for re-probe safety Dinh Nguyen
2026-07-27 13:24 ` [PATCH 08/10] EDAC/altera: Skip ECC memory init if already initialized Dinh Nguyen
2026-07-27 13:24 ` [PATCH 09/10] EDAC/altera: Detach sb_irq handler when db_irq setup fails Dinh Nguyen
2026-07-27 13:24 ` [PATCH 10/10] EDAC/altera: Fix error cleanup path in altr_edac_device_probe() Dinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260727132416.807230-4-dinguyen@kernel.org \
    --to=dinguyen@kernel.org \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=niravkumar.l.rabara@altera.com \
    --cc=rounakdas2025@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox