From: Borislav Petkov <bp@alien8.de>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: tony.luck@intel.com, rounakdas2025@gmail.com,
niravkumar.l.rabara@altera.com, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/1] EDAC/altera: Guard against NULL of_node
Date: Thu, 6 Aug 2026 18:16:45 +0000 [thread overview]
Message-ID: <20260806181645.GCanTPjVMp9VY1EPnX@fat_crate.local> (raw)
In-Reply-To: <20260806161055.1520446-1-dinguyen@kernel.org>
On Thu, Aug 06, 2026 at 11:10:54AM -0500, Dinh Nguyen wrote:
> Hi EDAC maintainers,
>
> I wanted to explain the reason why I think this patch doesn't need a
> Fixes tag. The way the Altera EDAC is written there are many instances
> of the driver referencing the of_node, which is why they are flagged in
> many sashiko reviews.
If you think this patch would make your life easier, then sure. But
we're not "fixing" the code just because a tool is stupid. No matter which
tool it is.
Thx.
prev parent reply other threads:[~2026-08-06 18:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 16:10 [PATCH 0/1] EDAC/altera: Guard against NULL of_node Dinh Nguyen
2026-08-06 16:10 ` [PATCH 1/1] EDAC/altera: Guard against NULL of_node pointer dereference Dinh Nguyen
2026-08-06 18:16 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260806181645.GCanTPjVMp9VY1EPnX@fat_crate.local \
--to=bp@alien8.de \
--cc=dinguyen@kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=niravkumar.l.rabara@altera.com \
--cc=rounakdas2025@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox