Linux EDAC development
 help / color / mirror / Atom feed
From: Abbott Liu <liuwenliang@huawei.com>
To: <tony.luck@intel.com>, <bp@alien8.de>, <jic23@kernel.org>,
	<ardb@kernel.org>, <rafael.j.wysocki@intel.com>,
	<guohanjun@huawei.com>, <mchehab+huawei@kernel.org>,
	<luoshengwei@huawei.com>, <jason@os.amperecomputing.com>,
	<danielf@os.amperecomputing.com>, <linux-edac@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: <liuwenliang@huawei.com>, <yangzhuohao1@huawei.com>,
	<douzhaolei@huawei.com>, <zouyipeng@huawei.com>,
	<wangbing6@huawei.com>, <nixiaoming@huawei.com>
Subject: [PATCH v2 0/2] RAS: Fix ARM processor error bounds checking
Date: Tue, 25 Aug 2026 21:43:21 +0800	[thread overview]
Message-ID: <20260825134323.4181892-1-liuwenliang@huawei.com> (raw)

Commit 87880af2d24e ("APEI/GHES: ARM processor Error: don't go past
allocated memory") and commit 05954511b73e ("RAS: Report all ARM
processor CPER information to userspace") introduced bounds checking
for malformed ARM processor error records in log_arm_hw_error().
However, two issues remain:

1. The ctx_info bounds check condition is inverted: it adds
   ctx_info->size when the context header is already past the end of
   the section instead of when it is within bounds.

2. When vsei_len < 0, the error path does not verify pei_len and
   ctx_len. Since these are derived from err_info_num and
   context_info_num, they may describe regions beyond the allocated
   record, causing trace_arm_event() to read out of bounds.

Patch 1 fixes the inverted bounds check for context info iteration.
Patch 2 sanitizes pei_len/ctx_len/ven_err_data in the vsei_len < 0
error path to prevent out-of-bounds reads in trace_arm_event().

Changes in v2:
  - Split the original single patch into two separate patches, one
    for each distinct fix, to ease review and backporting.

v1:
  RAS: Fix out-of-range section_length in ARM processor error handling
  https://lore.kernel.org/all/20260820131829.1006371-1-liuwenliang@huawei.com/

Abbott Liu (2):
  RAS: Fix inverted context info bounds check in ARM processor errors
  RAS: Fix out-of-bounds read when tracing arm_event

 drivers/ras/ras.c | 33 ++++++++++++++++++++++-----------
 1 file changed, 22 insertions(+), 11 deletions(-)

-- 
2.43.0


             reply	other threads:[~2026-08-25 13:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25 13:43 Abbott Liu [this message]
2026-08-25 13:43 ` [PATCH v2 1/2] RAS: Fix inverted context info bounds check in ARM processor errors Abbott Liu
2026-09-03  9:54   ` Hanjun Guo
2026-08-25 13:43 ` [PATCH v2 2/2] RAS: Fix out-of-bounds read when tracing arm_event Abbott Liu
2026-09-03  9:56   ` Hanjun Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260825134323.4181892-1-liuwenliang@huawei.com \
    --to=liuwenliang@huawei.com \
    --cc=ardb@kernel.org \
    --cc=bp@alien8.de \
    --cc=danielf@os.amperecomputing.com \
    --cc=douzhaolei@huawei.com \
    --cc=guohanjun@huawei.com \
    --cc=jason@os.amperecomputing.com \
    --cc=jic23@kernel.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luoshengwei@huawei.com \
    --cc=mchehab+huawei@kernel.org \
    --cc=nixiaoming@huawei.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=tony.luck@intel.com \
    --cc=wangbing6@huawei.com \
    --cc=yangzhuohao1@huawei.com \
    --cc=zouyipeng@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox