From: Borislav Petkov <bp@alien8.de>
To: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: Jasjeet Rangi <jrangi@purestorage.com>,
Smita.KoralahalliChannabasappa@amd.com,
dave.hansen@linux.intel.com, dgiani@purestorage.com,
hpa@zytor.com, linux-edac@vger.kernel.org, mingo@redhat.com,
msaggi@purestorage.com, rhan@purestorage.com,
rjethwani@purestorage.com, stable@vger.kernel.org,
tglx@kernel.org, tony.luck@intel.com, x86@kernel.org
Subject: Re: [PATCH v2 1/2] x86/mce/amd: Fix inverted interrupt enablement during storm handling
Date: Tue, 1 Sep 2026 13:11:27 -0700 [thread overview]
Message-ID: <20260901201127.GIapcxb5k-sW8TlV_2@fat_crate.local> (raw)
In-Reply-To: <20260819140647.GA2416@yaz-khff2.amd.com>
On Wed, Aug 19, 2026 at 10:06:47AM -0400, Yazen Ghannam wrote:
> IMO, disabling the interrupt is the best way to manage the storm. The
> reason for Intel to set a high limit is to keep the interrupt enabled.
> The reason to keep the interrupt enabled is because the same interrupt
> line is used for reporting "uncorrectable,no action" errors. This isn't
Where does it say that?
I guess still I can't search.
Because I see
c3629dd7e67d ("x86/mce: Prevent duplicate error records")
which did UCNA reporting with SMIs. And there it explains why you don't want
to disable CMCI.
Bottomline is, I don't mind toggling thresholding interrupts during storms but
this needs to be tested very thoroughly to confirm it actually does what we
expect it to do.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2026-09-01 20:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 22:15 [PATCH v2 0/2] x86/mce/amd: Fix inverted interrupt enablement during storm handling Jasjeet Rangi
2026-08-12 22:15 ` [PATCH v2 1/2] " Jasjeet Rangi
2026-08-14 23:24 ` Borislav Petkov
2026-08-17 18:51 ` Jasjeet Rangi
2026-08-18 19:02 ` Borislav Petkov
2026-08-19 6:46 ` Jasjeet Rangi
2026-08-19 14:06 ` Yazen Ghannam
2026-08-19 17:59 ` Jasjeet Rangi
2026-09-01 20:11 ` Borislav Petkov [this message]
2026-08-12 22:15 ` [PATCH v2 2/2] x86/mce: Rename MCE storm handler parameters for storm mode Jasjeet Rangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260901201127.GIapcxb5k-sW8TlV_2@fat_crate.local \
--to=bp@alien8.de \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=dave.hansen@linux.intel.com \
--cc=dgiani@purestorage.com \
--cc=hpa@zytor.com \
--cc=jrangi@purestorage.com \
--cc=linux-edac@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=msaggi@purestorage.com \
--cc=rhan@purestorage.com \
--cc=rjethwani@purestorage.com \
--cc=stable@vger.kernel.org \
--cc=tglx@kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox