From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Vishal Badole <Vishal.Badole@amd.com>
Cc: bp@alien8.de, tony.luck@intel.com, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] EDAC/amd64: Consolidate Family 1Ah model setup
Date: Thu, 15 Oct 2026 11:49:05 -0400 [thread overview]
Message-ID: <20261015154905.GB5279@yaz-khff2.amd.com> (raw)
In-Reply-To: <20261014085720.1471993-2-Vishal.Badole@amd.com>
On Wed, Oct 14, 2026 at 02:27:19PM +0530, Vishal Badole wrote:
> Every Family 1Ah model uses the v2 UMC register layout, and the driver
> must select it to decode memory errors correctly.
>
> So far each model had to select this itself. That is easy to forget when
> a new model is added, and a single missed flag quietly breaks error
> decoding. The driver also had no check for unknown models, so it would
> load on parts that were never tested and look supported when they are
> not.
>
> Handle the layout once for the whole family so no model can miss it, and
> do not load on models that are not known to work.
>
> Suggested-by: Yazen Ghannam <yazen.ghannam@amd.com>
> Signed-off-by: Vishal Badole <Vishal.Badole@amd.com>
> ---
Boris suggested the 'do not load' idea. That *could* be its own patch
and apply to all the families. IMO applying to all families is not worth
the churn, but splitting the patch is a toss up to me.
Overall, looks good.
Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>
Thanks,
Yazen
next prev parent reply other threads:[~2026-10-15 15:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 8:57 [PATCH 0/2] EDAC/amd64: Consolidate Family 1Ah setup and add support for models 0x88 ... 0x8f Vishal Badole
2026-10-14 8:57 ` [PATCH 1/2] EDAC/amd64: Consolidate Family 1Ah model setup Vishal Badole
2026-10-15 15:49 ` Yazen Ghannam [this message]
2026-10-14 8:57 ` [PATCH 2/2] EDAC/amd64: Add support for Family 1Ah models 0x88 ... 0x8f Vishal Badole
2026-10-15 15:54 ` Yazen Ghannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261015154905.GB5279@yaz-khff2.amd.com \
--to=yazen.ghannam@amd.com \
--cc=Vishal.Badole@amd.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox