From: Dinh Nguyen <dinguyen@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: tony.luck@intel.com, dbgh9129@gmail.com,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] EDAC/altera: Use parent device for devres in altr_portb_setup()
Date: Thu, 18 Jun 2026 03:27:43 -0500 [thread overview]
Message-ID: <3a2e32b9-d725-4bd6-bdb7-0081962cd3fc@kernel.org> (raw)
In-Reply-To: <20260617221834.GAajMdOocCPq39b-s0@fat_crate.local>
On 6/17/26 07:18, Borislav Petkov wrote:
> On Wed, Jun 17, 2026 at 11:43:03AM -0500, Dinh Nguyen wrote:
>> Anchor the devres group and the devm-managed IRQ requests in
>> altr_portb_setup() to the actual parent device (device->edac->dev)
>> instead of the embedded struct device inside the copied per-port
>> altr_edac_device_dev. This keeps devres_open_group(),
>> devm_request_irq(), devres_remove_group() and devres_release_group()
>> all referring to the same long-lived device so the group and the
>> resources allocated inside it are torn down together.
>>
>> Fixes: 911049845d70 ("EDAC, altera: Add Arria10 SD-MMC EDAC support")
>> Cc: stable@vger.kernel.org
>> Closes: https://sashiko.dev/#/patchset/20260503212558.2811480-1-dbgh9129%40gmail.com
>> Assisted-by: Claude:claude-opus-4-7
>> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
>> ---
>> drivers/edac/altera_edac.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> How urgent is this? Can it wait until the merge window is over?
>
Not urgent at all. It can wait until v7.2-rc1.
Thanks,
Dinh
prev parent reply other threads:[~2026-06-18 8:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-17 16:43 [PATCH] EDAC/altera: Use parent device for devres in altr_portb_setup() Dinh Nguyen
2026-06-17 22:18 ` Borislav Petkov
2026-06-18 8:27 ` Dinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a2e32b9-d725-4bd6-bdb7-0081962cd3fc@kernel.org \
--to=dinguyen@kernel.org \
--cc=bp@alien8.de \
--cc=dbgh9129@gmail.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox