linux-edac.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@xenotime.net>
To: bluesmoke-devel@lists.sourceforge.net
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
	Doug Thompson <dougthompson@xmission.com>
Subject: edac_i5[40]00 sparse warnings
Date: Thu, 25 Feb 2010 13:09:40 -0800	[thread overview]
Message-ID: <4B86E714.8090901@xenotime.net> (raw)

Hi,

drivers/edac/i5000_edac.c:496:15: warning: right shift by bigger than source value
drivers/edac/i5000_edac.c:591:23: warning: right shift by bigger than source value
drivers/edac/i5400_edac.c:401:36: warning: right shift by bigger than source value
drivers/edac/i5400_edac.c:411:37: warning: right shift by bigger than source value

It appears that
	u16 nrecmemb;
does not contain enough bits for these drivers.  ;)


i5000_edac:
#define			NREC_CAS(x)		(((x)>>16) & 0xFFFFFF)

where x is nrecmemb:
	cas = NREC_CAS(info->nrecmemb);
so 'cas' is always 0.  Maybe it is.


i5400_edac:
	return (info->nrecmemb) >> 31;
and
	return ((info->nrecmemb) >> 16) & 0x1fff;


-- 
~Randy

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

                 reply	other threads:[~2010-02-25 21:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B86E714.8090901@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=bluesmoke-devel@lists.sourceforge.net \
    --cc=dougthompson@xmission.com \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).