* edac_i5[40]00 sparse warnings
@ 2010-02-25 21:09 Randy Dunlap
0 siblings, 0 replies; only message in thread
From: Randy Dunlap @ 2010-02-25 21:09 UTC (permalink / raw)
To: bluesmoke-devel; +Cc: Mauro Carvalho Chehab, Doug Thompson
Hi,
drivers/edac/i5000_edac.c:496:15: warning: right shift by bigger than source value
drivers/edac/i5000_edac.c:591:23: warning: right shift by bigger than source value
drivers/edac/i5400_edac.c:401:36: warning: right shift by bigger than source value
drivers/edac/i5400_edac.c:411:37: warning: right shift by bigger than source value
It appears that
u16 nrecmemb;
does not contain enough bits for these drivers. ;)
i5000_edac:
#define NREC_CAS(x) (((x)>>16) & 0xFFFFFF)
where x is nrecmemb:
cas = NREC_CAS(info->nrecmemb);
so 'cas' is always 0. Maybe it is.
i5400_edac:
return (info->nrecmemb) >> 31;
and
return ((info->nrecmemb) >> 16) & 0x1fff;
--
~Randy
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-02-25 21:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-25 21:09 edac_i5[40]00 sparse warnings Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).