* [PATCH] edac: make inst_grp_ops const
@ 2010-08-31 22:24 Stephen Hemminger
2010-08-31 22:59 ` Doug Thompson
2010-08-31 23:00 ` Doug Thompson
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Hemminger @ 2010-08-31 22:24 UTC (permalink / raw)
To: Doug Thompson, Mauro Carvalho Chehab, bluesmoke-devel
This sysfs_ops should be const like all the others in the kernel.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/edac/edac_mc_sysfs.c 2010-08-31 15:10:29.692381171 -0700
+++ b/drivers/edac/edac_mc_sysfs.c 2010-08-31 15:11:24.072859199 -0700
@@ -764,7 +764,7 @@ static void edac_inst_grp_release(struct
}
/* Intermediate show/store table */
-static struct sysfs_ops inst_grp_ops = {
+static const struct sysfs_ops inst_grp_ops = {
.show = inst_grp_show,
.store = inst_grp_store
};
------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] edac: make inst_grp_ops const
2010-08-31 22:24 [PATCH] edac: make inst_grp_ops const Stephen Hemminger
@ 2010-08-31 22:59 ` Doug Thompson
2010-08-31 23:00 ` Doug Thompson
1 sibling, 0 replies; 4+ messages in thread
From: Doug Thompson @ 2010-08-31 22:59 UTC (permalink / raw)
To: Doug Thompson, Mauro Carvalho Chehab, bluesmoke-devel,
Stephen Hemminger
--- On Tue, 8/31/10, Stephen Hemminger <shemminger@vyatta.com> wrote:
> From: Stephen Hemminger <shemminger@vyatta.com>
> Subject: [PATCH] edac: make inst_grp_ops const
> To: "Doug Thompson" <dougthompson@xmission.com>, "Mauro Carvalho Chehab" <mchehab@redhat.com>, bluesmoke-devel@lists.sourceforge.net
> Date: Tuesday, August 31, 2010, 4:24 PM
> This sysfs_ops should be const like
> all the others in the kernel.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Doug Thompson <dougthompson@xmission.com>
>
> --- a/drivers/edac/edac_mc_sysfs.c
> 2010-08-31 15:10:29.692381171 -0700
> +++ b/drivers/edac/edac_mc_sysfs.c
> 2010-08-31 15:11:24.072859199 -0700
> @@ -764,7 +764,7 @@ static void
> edac_inst_grp_release(struct
> }
>
> /* Intermediate show/store table */
> -static struct sysfs_ops inst_grp_ops = {
> +static const struct sysfs_ops inst_grp_ops = {
> .show = inst_grp_show,
> .store = inst_grp_store
> };
>
------------------------------------------------------------------------------
This SF.net Dev2Dev email is sponsored by:
Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] edac: make inst_grp_ops const
2010-08-31 22:24 [PATCH] edac: make inst_grp_ops const Stephen Hemminger
2010-08-31 22:59 ` Doug Thompson
@ 2010-08-31 23:00 ` Doug Thompson
2010-09-01 10:42 ` Mauro Carvalho Chehab
1 sibling, 1 reply; 4+ messages in thread
From: Doug Thompson @ 2010-08-31 23:00 UTC (permalink / raw)
To: Doug Thompson, Mauro Carvalho Chehab, bluesmoke-devel,
Stephen Hemminger
Ignore that prior ack by me, I thought it was an i7core_edac module, not core EDAC modules.
I will take it myself and push it upstream
doug t
--- On Tue, 8/31/10, Stephen Hemminger <shemminger@vyatta.com> wrote:
> From: Stephen Hemminger <shemminger@vyatta.com>
> Subject: [PATCH] edac: make inst_grp_ops const
> To: "Doug Thompson" <dougthompson@xmission.com>, "Mauro Carvalho Chehab" <mchehab@redhat.com>, bluesmoke-devel@lists.sourceforge.net
> Date: Tuesday, August 31, 2010, 4:24 PM
> This sysfs_ops should be const like
> all the others in the kernel.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
> --- a/drivers/edac/edac_mc_sysfs.c
> 2010-08-31 15:10:29.692381171 -0700
> +++ b/drivers/edac/edac_mc_sysfs.c
> 2010-08-31 15:11:24.072859199 -0700
> @@ -764,7 +764,7 @@ static void
> edac_inst_grp_release(struct
> }
>
> /* Intermediate show/store table */
> -static struct sysfs_ops inst_grp_ops = {
> +static const struct sysfs_ops inst_grp_ops = {
> .show = inst_grp_show,
> .store = inst_grp_store
> };
>
------------------------------------------------------------------------------
This SF.net Dev2Dev email is sponsored by:
Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] edac: make inst_grp_ops const
2010-08-31 23:00 ` Doug Thompson
@ 2010-09-01 10:42 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 4+ messages in thread
From: Mauro Carvalho Chehab @ 2010-09-01 10:42 UTC (permalink / raw)
To: Doug Thompson; +Cc: Stephen Hemminger, bluesmoke-devel, Doug Thompson
Doug,
Em 31-08-2010 20:00, Doug Thompson escreveu:
>
> Ignore that prior ack by me, I thought it was an i7core_edac module, not core EDAC modules.
>
> I will take it myself and push it upstream
Please take a look first on my patch series. I've did lots of "const" cleanups
on my patch series, changing them on both i7core_edac and edac core.
I'm currently traveling, due to LinuxCon Brazil, but it is very likely that
this patch will conflict with one big patch I've made.
Cheers,
Mauro.
------------------------------------------------------------------------------
This SF.net Dev2Dev email is sponsored by:
Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-09-01 10:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-31 22:24 [PATCH] edac: make inst_grp_ops const Stephen Hemminger
2010-08-31 22:59 ` Doug Thompson
2010-08-31 23:00 ` Doug Thompson
2010-09-01 10:42 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).