From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="nUkGuZlf" Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAF1FD47 for ; Wed, 6 Dec 2023 06:11:48 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-3333131e08dso922349f8f.2 for ; Wed, 06 Dec 2023 06:11:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1701871907; x=1702476707; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/J/0AouVBy2ul+ViGYcNfPUia+BakLB5GkfP7lR2gNQ=; b=nUkGuZlf+Y1Z1F1+OQ5AT+w14Y+6oJ1lKcdwS3+glw+64GuP8tRqvZPLzC/730I3Ci 3o9QLMMOW1dtCa9bnhvoq6aSLxp6G8FbBPl6NXoGCW6SxXZf8Fe3VnSDpL4iWz2JnYpR RvaHwjHcEJ4lkoobY6DkqPKKq7sQu3yi6ivSI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701871907; x=1702476707; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/J/0AouVBy2ul+ViGYcNfPUia+BakLB5GkfP7lR2gNQ=; b=LQUYwMLNIeSJo4o9KeHvFjdUGDOoUPcem+x28lsAd3Z7eYX7AkePzyF9lrCrnV4WYG tuAhT5uakzFKZMlkrTx5mvdF4NR3clgww4m0o5u7sC/pK8w7bq2NXjWr04E54+tJuuEx iktmWbqn19USIqBFUBv/X2zfN96h45qQyp99lkKx+MvZlQmT0RgHdBprTgPx/F++LbAd Z9G4UjCEQ/1qCN0ziC5oMU71RCb0BXnTO8nfApT6v4GmIVFchXyCtCJWLZcivBZDlgof 9q23GeQNwhl41HHz+dggdmJAJh6S5MF9GWh1bBbSyOR7jMM04523iozlP2HaSZ0Abq4P i92A== X-Gm-Message-State: AOJu0Yy2636/AOdFqTgFik9VmBv5PKoC7VNiRk0DD1f4/DlmRGkgX1ay 87vWEFd4jMh8MAqJwLuvw15mzg== X-Google-Smtp-Source: AGHT+IFNMx+Klo1CEPaJ26/dBlw3sjXlNL46V08+iyKrIoZzyUVgJsGVXWSyD7pSk5JuLC7WZwHGiw== X-Received: by 2002:a05:600c:5253:b0:40b:5e4a:4081 with SMTP id fc19-20020a05600c525300b0040b5e4a4081mr623446wmb.161.1701871907211; Wed, 06 Dec 2023 06:11:47 -0800 (PST) Received: from [10.80.67.30] (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id c1-20020adfa301000000b003333a216682sm11793864wrb.97.2023.12.06.06.11.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Dec 2023 06:11:46 -0800 (PST) Message-ID: <4e41b658-f49e-424c-8a86-08c8ab8e384d@citrix.com> Date: Wed, 6 Dec 2023 14:11:46 +0000 Precedence: bulk X-Mailing-List: linux-edac@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 26/35] x86/fred: FRED entry/exit and dispatch code Content-Language: en-GB To: "Li, Xin3" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "kvm@vger.kernel.org" , "xen-devel@lists.xenproject.org" Cc: "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "Lutomirski, Andy" , "pbonzini@redhat.com" , "seanjc@google.com" , "peterz@infradead.org" , "Gross, Jurgen" , "Shankar, Ravi V" , "mhiramat@kernel.org" , "jiangshanlai@gmail.com" , "nik.borisov@suse.com" , "Kang, Shan" References: <20231205105030.8698-1-xin3.li@intel.com> <20231205105030.8698-27-xin3.li@intel.com> From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 06/12/2023 7:45 am, Li, Xin3 wrote: >>> + case X86_TRAP_OF: >>> + exc_overflow(regs); >>> + return; >>> + >>> + /* INT3 */ >>> + case X86_TRAP_BP: >>> + exc_int3(regs); >>> + return; >> ... neither OF nor BP will ever enter fred_intx() because they're type SWEXC not >> SWINT. > Per FRED spec 5.0, section 7.3 Software Interrupts and Related Instructions: > INT n (opcode CD followed by an immediate byte): There are 256 such > software interrupt instructions, one for each value n of the immediate > byte (0–255). > > And appendix B Event Stack Levels: > If the event is an execution of INT n (opcode CD n for 8-bit value n), > the event stack level is 0. The event type is 4 (software interrupt) > and the vector is n. > > So int $0x4 and int $0x3 (use asm(".byte 0xCD, 0x03")) get here. > > But into (0xCE) and int3 (0xCC) do use event type SWEXC. > > BTW, into is NOT allowed in 64-bit mode but "int $0x4" is allowed. There is certainly fun to be had with CD 03 and CD 04 byte patterns, but if you meant to mean those here, then the comments are wrong. Vectors 3 and 4 are installed with DPL3 because that is necessary to make CC and CE function in userspace.  It also suggests that the SWINT vs SWEXC distinction was retrofitted to architecture after the 286, because exceptions don't check DPL and ICEBP delivers #DB from userspace even when Vector 1 has a DPL of 0. While CC is for most cases indistinguishable from CD 03, CE behaves entirely differently to CD 04.  CD 04 doesn't #UD in 64bit mode, and will trigger exc_overflow() irrespective of the state of EFLAGS.OF. The SDM goes out of it's way to say not to use the CD 03 byte pattern (and it does take effort to emit this byte pattern - e.g. GAS will silently translate "int $3" to "int3"), and there's no plausible way software is using CD 04 in place of CE. So why do we care about containing to make mistakes of the IDT era work in a FRED world? Is there anything (other than perhaps the selftests) which would even notice? >>> + instrumentation_end(); >>> + irqentry_exit(regs, state); >>> + } else { >>> + common_interrupt(regs, vector); >>> + } >>> +} >>> + >>> +static noinstr void fred_exception(struct pt_regs *regs, unsigned >>> +long error_code) { >>> + /* Optimize for #PF. That's the only exception which matters performance >> wise */ >>> + if (likely(regs->fred_ss.vector == X86_TRAP_PF)) { >>> + exc_page_fault(regs, error_code); >>> + return; >>> + } >>> + >>> + switch (regs->fred_ss.vector) { >>> + case X86_TRAP_DE: return exc_divide_error(regs); >>> + case X86_TRAP_DB: return fred_exc_debug(regs); >>> + case X86_TRAP_BP: return exc_int3(regs); >>> + case X86_TRAP_OF: return exc_overflow(regs); >> Depending on what you want to do with BP/OF vs fred_intx(), this may need >> adjusting. >> >> If you are cross-checking type and vector, then these should be rejected for not >> being of type HWEXC. > You're right, the event type needs to be SWEXC for into and int3. > > However, would it be overkilling? Assuming hardware and VMM are sane. You either care about cross checking, or not.  Right now, this patch is a mix of the two approaches. In my opinion, cross-checking is the better approach, because it means that violations of the assumptions get noticed more quickly, and hopefully by whomever is working on the new feature which alters the assumptions. ~Andrew