Re: [PATCH V2 1/4] rasdaemon: Move definition for BIT and BIT_ULL to a common file

Dave Jiang
2023-01-25T16:34:18Z

On 1/24/23 9:57 AM, shiju.jose@huawei.com wrote:
> From: Shiju Jose <shiju.jose@huawei.com>
>
> Move definition for BIT() and BIT_ULL() to the
> common file ras-record.h
>
> Signed-off-by: Shiju Jose <shiju.jose@huawei.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>

> ---
> ras-non-standard-handler.h | 3 ---
> ras-record.h | 3 +++
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/ras-non-standard-handler.h b/ras-non-standard-handler.h
> index 4d9f938..c360eaf 100644
> --- a/ras-non-standard-handler.h
> +++ b/ras-non-standard-handler.h
> @@ -17,9 +17,6 @@
> #include "ras-events.h"
> #include <traceevent/event-parse.h>
>
> -#define BIT(nr) (1UL << (nr))
> -#define BIT_ULL(nr) (1ULL << (nr))
> -
> struct ras_ns_ev_decoder {
> struct ras_ns_ev_decoder *next;
> const char *sec_type;
> diff --git a/ras-record.h b/ras-record.h
> index d9f7733..219f10b 100644
> --- a/ras-record.h
> +++ b/ras-record.h
> @@ -25,6 +25,9 @@
>
> #define ARRAY_SIZE(x) (sizeof(x)/sizeof(*(x)))
>
> +#define BIT(nr) (1UL << (nr))
> +#define BIT_ULL(nr) (1ULL << (nr))
> +
> extern long user_hz;
>
> struct ras_events;