From: Paolo Bonzini <pbonzini@redhat.com>
To: Borislav Petkov <bp@alien8.de>, Pu Wen <puwen@hygon.cn>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, thomas.lendacky@amd.com, mchehab@kernel.org,
mikhail.jin@gmail.com, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, linux-edac@vger.kernel.org
Subject: [v4,15/16] driver/edac: enable Hygon support to AMD64 EDAC driver
Date: Tue, 21 Aug 2018 13:26:13 +0200 [thread overview]
Message-ID: <6e17958a-6cd8-4c6c-c890-f5f48b084d6f@redhat.com> (raw)
On 21/08/2018 13:20, Borislav Petkov wrote:
> On Tue, Aug 21, 2018 at 07:04:23PM +0800, Pu Wen wrote:
>> Sure, JV will negotiate with AMD and make sure only JV use family 18h and
>> AMD won't use family 0x18h, which will make the patch tight and clear.
>>
>> What's the best way to adapt for EDAC driver?
>> * To simplify the code based on AMD won't do family 0x18 and remove
>> vendor checking.
>
> That, provided AMD won't use family 0x18.
>
But then I don't see the point of adding the Hygon vendor, since any
check can be simplified:
(AMD || HYGON) -->
AMD
(AMD && fam = 17h) || (HYGON && fam = 18h) -->
AMD && (fam = 17h || fam = 18h)
(AMD && fam = 17h) || HYGON -->
AMD && (fam = 17h || fam = 18h)
etc. Anyway, I don't care much either way.
Paolo
next reply other threads:[~2018-08-21 11:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 11:26 Paolo Bonzini [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-08-23 8:27 [v4,15/16] driver/edac: enable Hygon support to AMD64 EDAC driver Borislav Petkov
2018-08-22 13:18 Pu Wen
2018-08-22 13:07 Pu Wen
2018-08-21 18:07 Pavel Machek
2018-08-21 13:04 Borislav Petkov
2018-08-21 11:20 Borislav Petkov
2018-08-21 11:04 Pu Wen
2018-08-21 8:13 Borislav Petkov
2018-08-19 16:14 Pu Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e17958a-6cd8-4c6c-c890-f5f48b084d6f@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mikhail.jin@gmail.com \
--cc=mingo@redhat.com \
--cc=puwen@hygon.cn \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).