Re: [PATCH] RAS/AMD/ATL: Decrease message about unknown DF revision to debug

[Mario Limonciello <mario.limonciello@amd.com>]

On 3/19/2026 9:36 AM, Yazen Ghannam wrote:
> On Wed, Mar 18, 2026 at 10:43:04AM -0500, Mario Limonciello wrote:
> 
> [...]
> 
>>> diff --git a/drivers/ras/amd/atl/core.c b/drivers/ras/amd/atl/core.c
>>> index 0f7cd6dab0b0..d77dacdd4f56 100644
>>> --- a/drivers/ras/amd/atl/core.c
>>> +++ b/drivers/ras/amd/atl/core.c
>>> @@ -190,7 +190,6 @@ static const struct x86_cpu_id amd_atl_cpuids[] = {
>>>    	X86_MATCH_FEATURE(X86_FEATURE_ZEN, NULL),
>>>    	{ }
>>>    };
>>> -MODULE_DEVICE_TABLE(x86cpu, amd_atl_cpuids);
>>
>> Pretty sure this means you can drop amd_atl_cpuids as well.
> 
> Yeah, maybe.
> 
> The request_module() in EDAC is unconditional. We use the same EDAC
> module for multiple generations of CPUs.
> 
> The amd_atl_cpuids check will keep the amd_atl module off the legacy
> systems.
> 
> We could redo the flow. But there needs to be a feature check somewhere.
> The proposed patch is the smallest diff I thought of at the time.
> 
> Thanks,
> Yazen

Well to be fair there was CPU no check before  - the module device table 
just controlled automatic loading.

But yeah I think a simple cpu feature check during probe along with the 
suggested change would solve this.