From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24E6D6FB6; Fri, 18 Oct 2024 00:09:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729210147; cv=none; b=cST8LYtGFPvHS1NjxVsM07cwmv3Y43I+96uwIItGX1WrGNC7FoZu3nkYZmXVCltzryu9K90suTiAx2l8a99JKxXM6pExKFj1ShMWIZDGtsdz4fOmuhx26K7xMX6GDe+0ipg/NN5lDdgG6aJREK+YjvwEzzoqsECWUvTRWbQtxyA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729210147; c=relaxed/simple; bh=mQPM1pH8yD5jSbTcIrl78Q+k4c+ekIYxXoz4DoEeLP8=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=gKcblmNlwnMesTSRI5seWMZx7aRw9aWyLYPdHAWoHnePSTDEXFhOF7CNEDyaU21nVi5yuDcNo1sWCzykHXEyNGAWr7teAHMv2LFzDFM4ZshTVqxaU1lvqoOoYWBL3uDYfl6pfuf8I628AHct9ixzS66rxskJnz4utBT3b7OX92g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=WZoMf++t; arc=none smtp.client-ip=115.124.30.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="WZoMf++t" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1729210142; h=Message-ID:Date:MIME-Version:From:Subject:To:Content-Type; bh=Io75B3fvXXRmUHmAeKwtQ0SdGJZvo/arwhIScIU6xXg=; b=WZoMf++tt1SvwR9gZfagvE79Nql2zcE9+jMMvR93QiZkSbuU/wspk5qNMMK7QHJxZVQ+tc6X68B49o6VivhN72Dz6Am0jUci4YywuL/X+T1nG14aY5OfE33rPiQ75oexY5VEFwxVImIEc2nWW9T9IZ9YOQVZwI1Y+DNRVtTUazU= Received: from 30.246.161.56(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0WHM.wlo_1729210139 cluster:ay36) by smtp.aliyun-inc.com; Fri, 18 Oct 2024 08:09:00 +0800 Message-ID: <75ec37d9-f0cd-4fd5-8f81-7bfdc8b4e3c6@linux.alibaba.com> Date: Fri, 18 Oct 2024 08:08:58 +0800 Precedence: bulk X-Mailing-List: linux-edac@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Shuai Xue Subject: Re: [PATCH v14 3/3] ACPI: APEI: handle synchronous exceptions in task work To: Jonathan Cameron Cc: mark.rutland@arm.com, catalin.marinas@arm.com, mingo@redhat.com, robin.murphy@arm.com, bp@alien8.de, rafael@kernel.org, wangkefeng.wang@huawei.com, tanxiaofei@huawei.com, mawupeng1@huawei.com, tony.luck@intel.com, linmiaohe@huawei.com, naoya.horiguchi@nec.com, james.morse@arm.com, tongtiangen@huawei.com, gregkh@linuxfoundation.org, will@kernel.org, jarkko@kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-edac@vger.kernel.org, x86@kernel.org, justin.he@arm.com, ardb@kernel.org, ying.huang@intel.com, ashish.kalra@amd.com, baolin.wang@linux.alibaba.com, tglx@linutronix.de, dave.hansen@linux.intel.com, lenb@kernel.org, hpa@zytor.com, robert.moore@intel.com, lvying6@huawei.com, xiexiuqi@huawei.com, zhuo.song@linux.alibaba.com References: <20221027042445.60108-1-xueshuai@linux.alibaba.com> <20241014084240.18614-4-xueshuai@linux.alibaba.com> <20241017105621.00000c1e@Huawei.com> In-Reply-To: <20241017105621.00000c1e@Huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 在 2024/10/17 17:56, Jonathan Cameron 写道: > On Mon, 14 Oct 2024 16:42:40 +0800 > Shuai Xue wrote: > >> The memory uncorrected error could be signaled by asynchronous interrupt >> (specifically, SPI in arm64 platform), e.g. when an error is detected by >> a background scrubber, or signaled by synchronous exception >> (specifically, data abort excepction in arm64 platform), e.g. when a CPU > > exception > >> tries to access a poisoned cache line. Currently, both synchronous and >> asynchronous error use memory_failure_queue() to schedule >> memory_failure() exectute in kworker context. > memory_failure() to execute in kworker context. > > (spell check in general) Sorry for typos. Will fix it in next version. Thanks. >> >> As a result, when a user-space process is accessing a poisoned data, a >> data abort is taken and the memory_failure() is executed in the kworker >> context: > context, memory_failure(): > //No subject of the following two bullets otherwise. I see, will fix it. >> >> - will send wrong si_code by SIGBUS signal in early_kill mode, and >> - can not kill the user-space in some cases resulting a synchronous >> error infinite loop >> >> Issue 1: send wrong si_code in early_kill mode >> >> Since commit a70297d22132 ("ACPI: APEI: set memory failure flags as >> MF_ACTION_REQUIRED on synchronous events")', the flag MF_ACTION_REQUIRED >> could be used to determine whether a synchronous exception occurs on >> ARM64 platform. When a synchronous exception is detected, the kernel is >> expected to terminate the current process which has accessed poisoned >> page. This is done by sending a SIGBUS signal with an error code >> BUS_MCEERR_AR, indicating an action-required machine check error on >> read. >> >> However, when kill_proc() is called to terminate the processes who have >> the poisoned page mapped, it sends the incorrect SIGBUS error code >> BUS_MCEERR_AO because the context in which it operates is not the one >> where the error was triggered. >> >> To reproduce this problem: >> >> #sysctl -w vm.memory_failure_early_kill=1 >> vm.memory_failure_early_kill = 1 >> >> # STEP2: inject an UCE error and consume it to trigger a synchronous error >> #einj_mem_uc single >> 0: single vaddr = 0xffffb0d75400 paddr = 4092d55b400 >> injecting ... >> triggering ... >> signal 7 code 5 addr 0xffffb0d75000 >> page not present >> Test passed >> >> The si_code (code 5) from einj_mem_uc indicates that it is BUS_MCEERR_AO >> error and it is not fact. >> >> After this patch: >> >> # STEP1: enable early kill mode >> #sysctl -w vm.memory_failure_early_kill=1 >> vm.memory_failure_early_kill = 1 >> # STEP2: inject an UCE error and consume it to trigger a synchronous error >> #einj_mem_uc single >> 0: single vaddr = 0xffffb0d75400 paddr = 4092d55b400 >> injecting ... >> triggering ... >> signal 7 code 4 addr 0xffffb0d75000 >> page not present >> Test passed >> >> The si_code (code 4) from einj_mem_uc indicates that it is BUS_MCEERR_AR >> error as we expected. >> >> Issue 2: a synchronous error infinite loop >> >> If a user-space process, e.g. devmem, a poisoned page which has been set > > devmem accesses a poisoned page for which the HWPoison flag is set > >> HWPosion flag, kill_accessing_process() is called to send SIGBUS to the >> current processs with error info. Because the memory_failure() is >> executed in the kworker contex, it will just do nothing but return > > context > >> EFAULT. So, devmem will access the posioned page and trigger an >> excepction again, resulting in a synchronous error infinite loop. Such > > exception I see, will fix it. > >> loop may cause platform firmware to exceed some threshold and reboot >> when Linux could have recovered from this error. >> >> To reproduce this problem: >> >> # STEP 1: inject an UCE error, and kernel will set HWPosion flag for related page >> #einj_mem_uc single >> 0: single vaddr = 0xffffb0d75400 paddr = 4092d55b400 >> injecting ... >> triggering ... >> signal 7 code 4 addr 0xffffb0d75000 >> page not present >> Test passed >> >> # STEP 2: access the same page and it will trigger a synchronous error infinite loop >> devmem 0x4092d55b400 >> >> To fix above two issues, queue memory_failure() as a task_work so that it runs in >> the context of the process that is actually consuming the poisoned data. >> >> Signed-off-by: Shuai Xue >> Tested-by: Ma Wupeng >> Reviewed-by: Kefeng Wang >> Reviewed-by: Xiaofei Tan >> Reviewed-by: Baolin Wang > One other trivial comment inline. > > Whilst this also looks fine to me, there are others who (hopefully) > understand these paths better than me. With that said. > > Reviewed-by: Jonathan Cameron Thank you for valuable comments. > >> --- >> drivers/acpi/apei/ghes.c | 78 +++++++++++++++++++++++----------------- >> include/acpi/ghes.h | 3 -- >> include/linux/mm.h | 1 - >> mm/memory-failure.c | 13 ------- >> 4 files changed, 45 insertions(+), 50 deletions(-) >> >> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c >> index f2ee28c44d7a..95e9520eb803 100644 >> --- a/drivers/acpi/apei/ghes.c >> +++ b/drivers/acpi/apei/ghes.c >> @@ -467,28 +467,42 @@ static void ghes_clear_estatus(struct ghes *ghes, >> } >> >> /* >> - * Called as task_work before returning to user-space. >> - * Ensure any queued work has been done before we return to the context that >> - * triggered the notification. >> + * struct ghes_task_work - for synchronous RAS event >> + * >> + * @twork: callback_head for task work >> + * @pfn: page frame number of corrupted page >> + * @flags: work control flags >> + * >> + * Structure to pass task work to be handled before >> + * returning to user-space via task_work_add(). >> */ >> -static void ghes_kick_task_work(struct callback_head *head) >> +struct ghes_task_work { >> + struct callback_head twork; >> + u64 pfn; >> + int flags; >> +}; >> + >> +static void memory_failure_cb(struct callback_head *twork) >> { >> - struct acpi_hest_generic_status *estatus; >> - struct ghes_estatus_node *estatus_node; >> - u32 node_len; >> + struct ghes_task_work *twcb = container_of(twork, struct ghes_task_work, twork); >> + unsigned long pfn = twcb->pfn; > > This local variable is not used consistently. I'd just > drop it in favor of always accessing via twcb->pfn Agreed, will remove local pfn. Best Regards, Shuai