From: Dinh Nguyen <dinguyen@kernel.org>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: bp@alien8.de, mchehab@kernel.org, tony.luck@intel.com,
james.morse@arm.com, rric@kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] EDAC/altera: Remove unnecessary print function dev_err()
Date: Mon, 21 Mar 2022 10:10:16 -0500 [thread overview]
Message-ID: <79f5594f-2864-4df8-c04b-6d1c3f8a764c@kernel.org> (raw)
In-Reply-To: <20220317233722.109036-1-yang.lee@linux.alibaba.com>
On 3/17/22 18:37, Yang Li wrote:
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> Eliminate the follow coccicheck warnings:
> ./drivers/edac/altera_edac.c:2153:2-9: line 2153 is redundant because
> platform_get_irq() already prints an error
> ./drivers/edac/altera_edac.c:2188:2-9: line 2188 is redundant because
> platform_get_irq() already prints an error
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/edac/altera_edac.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
> index e7e8e624a436..47dc35938fa8 100644
> --- a/drivers/edac/altera_edac.c
> +++ b/drivers/edac/altera_edac.c
> @@ -2149,10 +2149,8 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
> }
>
> edac->sb_irq = platform_get_irq(pdev, 0);
> - if (edac->sb_irq < 0) {
> - dev_err(&pdev->dev, "No SBERR IRQ resource\n");
> + if (edac->sb_irq < 0)
> return edac->sb_irq;
> - }
>
> irq_set_chained_handler_and_data(edac->sb_irq,
> altr_edac_a10_irq_handler,
> @@ -2184,10 +2182,8 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
> }
> #else
> edac->db_irq = platform_get_irq(pdev, 1);
> - if (edac->db_irq < 0) {
> - dev_err(&pdev->dev, "No DBERR IRQ resource\n");
> + if (edac->db_irq < 0)
> return edac->db_irq;
> - }
> irq_set_chained_handler_and_data(edac->db_irq,
> altr_edac_a10_irq_handler, edac);
> #endif
Acked-by: Dinh Nguyen <dinguyen@kernel.org>
prev parent reply other threads:[~2022-03-21 15:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 23:37 [PATCH -next] EDAC/altera: Remove unnecessary print function dev_err() Yang Li
2022-03-21 15:10 ` Dinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79f5594f-2864-4df8-c04b-6d1c3f8a764c@kernel.org \
--to=dinguyen@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox