From: Dinh Nguyen <dinguyen@kernel.org>
To: Sergey Shtylyov <s.shtylyov@omp.ru>,
Borislav Petkov <bp@alien8.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Tony Luck <tony.luck@intel.com>,
James Morse <james.morse@arm.com>,
Robert Richter <rric@kernel.org>,
linux-edac@vger.kernel.org
Subject: Re: [PATCH 1/2] edac: altera: fix deferred probing
Date: Wed, 26 Jan 2022 10:52:20 -0600 [thread overview]
Message-ID: <7b964ac0-6356-9330-a745-b43e620d051b@kernel.org> (raw)
In-Reply-To: <20220124185503.6720-2-s.shtylyov@omp.ru>
On 1/24/22 12:55, Sergey Shtylyov wrote:
> The driver overrides the error codes returned by platform_get_irq() to
> -ENODEV for some strange reason, so if it returns -EPROBE_DEFER, the
> driver will fail the probe permanently instead of the deferred probing.
> Switch to propagating the error codes upstream.
>
> Fixes: 71bcada88b0f ("edac: altera: Add Altera SDRAM EDAC support")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> ---
> drivers/edac/altera_edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
> index 3a6d2416cb0f..5dd29789f97d 100644
> --- a/drivers/edac/altera_edac.c
> +++ b/drivers/edac/altera_edac.c
> @@ -350,7 +350,7 @@ static int altr_sdram_probe(struct platform_device *pdev)
> if (irq < 0) {
> edac_printk(KERN_ERR, EDAC_MC,
> "No irq %d in DT\n", irq);
> - return -ENODEV;
> + return irq;
> }
>
> /* Arria10 has a 2nd IRQ */
Acked-by: Dinh Nguyen <dinguyen@kernel.org>
next prev parent reply other threads:[~2022-01-26 16:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 18:55 [PATCH 0/2] Fix deferred probing in the EDAC drivers Sergey Shtylyov
2022-01-24 18:55 ` [PATCH 1/2] edac: altera: fix deferred probing Sergey Shtylyov
2022-01-26 16:52 ` Dinh Nguyen [this message]
2022-01-28 18:36 ` Borislav Petkov
2022-01-28 18:53 ` Sergey Shtylyov
2022-01-28 19:02 ` Sergey Shtylyov
2022-01-28 19:16 ` Borislav Petkov
2022-01-28 19:17 ` Sergey Shtylyov
2022-01-28 19:20 ` Borislav Petkov
2022-01-28 19:35 ` Sergey Shtylyov
2022-01-28 19:47 ` Sergey Shtylyov
2022-01-29 6:48 ` Greg KH
2022-01-29 10:33 ` Borislav Petkov
2022-01-28 19:53 ` Sergey Shtylyov
2022-01-28 19:56 ` Sergey Shtylyov
2022-01-24 18:55 ` [PATCH 2/2] edac: xgene: " Sergey Shtylyov
2022-01-28 22:39 ` [PATCH 0/2] Fix deferred probing in the EDAC drivers Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b964ac0-6356-9330-a745-b43e620d051b@kernel.org \
--to=dinguyen@kernel.org \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=s.shtylyov@omp.ru \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox