Re: [PATCH v4] vmcoreinfo: Track and log recoverable hardware errors

Dave Hansen
2025-08-04T17:41:21Z

On 8/4/25 10:12, Breno Leitao wrote:
...
> +- These errros are divided by are, which includes CPU, Memory, PCI, CXL and
> + others.

There's a double typo in there I think:

errros => errors
and
are,=>area,

> --- a/include/linux/vmcore_info.h
> +++ b/include/linux/vmcore_info.h
> @@ -77,4 +77,20 @@ extern u32 *vmcoreinfo_note;
> Elf_Word *append_elf_note(Elf_Word *buf, char *name, unsigned int type,
> void *data, size_t data_len);
> void final_note(Elf_Word *buf);
> +
> +enum hwerr_error_type {
> + HWERR_RECOV_CPU,
> + HWERR_RECOV_MEMORY,
> + HWERR_RECOV_PCI,
> + HWERR_RECOV_CXL,
> + HWERR_RECOV_OTHERS,
> + HWERR_RECOV_MAX,
> +};
That enum needs to go into an abi header.

Otherwise, this is starting to look sane to me.