From: Xi Ruoyao <xry111@xry111.site>
To: Zhao Qunqin <zhaoqunqin@loongson.cn>,
chenhuacai@kernel.org, kernel@xen0n.name, bp@alien8.de,
tony.luck@intel.com, james.morse@arm.com, mchehab@kernel.org,
rric@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org
Cc: loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-edac@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 1/2] Loongarch: EDAC driver for loongson memory controller
Date: Wed, 21 Aug 2024 14:51:45 +0800 [thread overview]
Message-ID: <85d64a341fa0d2dd57ed1078b694effc90b2e33e.camel@xry111.site> (raw)
In-Reply-To: <20240821064728.8642-2-zhaoqunqin@loongson.cn>
On Wed, 2024-08-21 at 14:47 +0800, Zhao Qunqin wrote:
> --- a/arch/loongarch/Kconfig
> +++ b/arch/loongarch/Kconfig
> @@ -179,6 +179,8 @@ config LOONGARCH
> select PCI_QUIRKS
> select PERF_USE_VMALLOC
> select RTC_LIB
> + select EDAC_SUPPORT
> + select EDAC
This line looks incorrect. It's forcing the users to enable EDAC even
if they don't need it (for example using a non-ECC memory).
And no other arch does this.
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2024-08-21 6:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 6:47 [PATCH v1 0/2] Add EDAC driver for loongson memory controller Zhao Qunqin
2024-08-21 6:47 ` [PATCH v1 1/2] Loongarch: " Zhao Qunqin
2024-08-21 6:51 ` Xi Ruoyao [this message]
2024-08-21 8:24 ` Krzysztof Kozlowski
2024-08-22 0:07 ` kernel test robot
2024-08-22 3:14 ` kernel test robot
2024-08-23 2:42 ` kernel test robot
2024-08-21 6:47 ` [PATCH v1 2/2] dt-bindings: EDAC " Zhao Qunqin
2024-08-21 8:18 ` Rob Herring (Arm)
2024-08-21 8:20 ` Krzysztof Kozlowski
2024-08-21 14:59 ` Conor Dooley
2024-08-28 2:24 ` Zhao Qunqin
2024-08-21 7:01 ` [PATCH v1 0/2] Add EDAC driver " Xi Ruoyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85d64a341fa0d2dd57ed1078b694effc90b2e33e.camel@xry111.site \
--to=xry111@xry111.site \
--cc=bp@alien8.de \
--cc=chenhuacai@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=james.morse@arm.com \
--cc=kernel@xen0n.name \
--cc=krzk+dt@kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=zhaoqunqin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox