public inbox for linux-edac@vger.kernel.org
 help / color / mirror / Atom feed
From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Tom Rix <trix@redhat.com>,
	bp@alien8.de, tony.luck@intel.com, james.morse@arm.com,
	mchehab@kernel.org, rric@kernel.org
Cc: yazen.ghannam@amd.com, linux-edac@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EDAC/amd64: set variable gpu_node_map storage-class-specifier to static
Date: Wed, 14 Jun 2023 11:21:46 -0400	[thread overview]
Message-ID: <89a67e4d-cada-ff57-f702-d5579ea8b39c@amd.com> (raw)
In-Reply-To: <20230610210930.174074-1-trix@redhat.com>

On 6/10/2023 5:09 PM, Tom Rix wrote:
> smatch reports
> drivers/edac/amd64_edac.c:990:3: warning: symbol
>    'gpu_node_map' was not declared. Should it be static?
> 
> This variable is only used in its defining file, so it should be static.
> 

Hi Tom,

Please use "imperative mood" when describing the change.

"This variable is only used in its defining file, so add the 'static' 
keyword to it."

or

"Make gpu_node_map static, since it's only used in its defining file."

Also, would a Fixes tag be appropriate?

Otherwise, looks good to me.

Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>

Thanks,
Yazen

  reply	other threads:[~2023-06-14 15:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-10 21:09 [PATCH] EDAC/amd64: set variable gpu_node_map storage-class-specifier to static Tom Rix
2023-06-14 15:21 ` Yazen Ghannam [this message]
2023-06-19 11:07   ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89a67e4d-cada-ff57-f702-d5579ea8b39c@amd.com \
    --to=yazen.ghannam@amd.com \
    --cc=bp@alien8.de \
    --cc=james.morse@arm.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=rric@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox