Re: [PATCH] EDAC: Use string choice helper functions

Yazen Ghannam
2025-02-13T17:41:19Z

On Sun, Feb 09, 2025 at 10:52:21PM +0100, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_enabled_disabled(),
> str_yes_no(), str_write_read(), and str_plural() helper functions.
>
> Add a space in "All DIMMs support ECC: yes/no" to improve readability.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> drivers/edac/amd64_edac.c | 47 +++++++++++++++++++--------------------
> drivers/edac/debugfs.c | 5 ++++-
> drivers/edac/i5400_edac.c | 3 ++-
> drivers/edac/i7300_edac.c | 7 +++---
> drivers/edac/xgene_edac.c | 17 +++++++-------
> 5 files changed, 42 insertions(+), 37 deletions(-)
>

Please do include a base commit id. This patch doesn't apply to
ras/edac-for-next but does apply to mainline/master.

In any case, looks good to me.

Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>

Is there any effort to make folks aware of these helpers? Maybe an
addition to checkpatch (as a CHECK/suggestion)?

Thanks,
Yazen