Linux EDAC development
 help / color / mirror / Atom feed
From: "Paul Louvel" <paul.louvel@bootlin.com>
To: "Wolfram Sang" <wsa+renesas@sang-engineering.com>,
	"Paul Louvel" <paul.louvel@bootlin.com>
Cc: "Borislav Petkov" <bp@alien8.de>,
	"Tony Luck" <tony.luck@intel.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	<linux-kernel@vger.kernel.org>,
	<linux-renesas-soc@vger.kernel.org>, <linux-edac@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Herve Codina" <herve.codina@bootlin.com>
Subject: Re: [PATCH v7 3/3] ARM: dts: renesas: r9a06g032: add EDAC node
Date: Tue, 17 Nov 2026 14:46:15 +0100	[thread overview]
Message-ID: <DMXJ5VMIPGL9.1917ON486UJRD@bootlin.com> (raw)
In-Reply-To: <avxR5VZESPLklIuG@ninjato>

Hi Wolfram,

On Tue Nov 17, 2026 at 2:08 PM CET, Wolfram Sang wrote:
>
>> +		edac: memory-controller@4000d000 {
>> +			compatible = "renesas,r9a06g032-ddr-edac", "cdns,ddr-edac";
>> +			reg = <0x4000d000 0x1000>;
>> +			interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;
>> +			clocks = <&sysctrl R9A06G032_CLK_DDRC>, <&sysctrl R9A06G032_HCLK_DDRC>;
>> +			clock-names = "ddrc", "pclk";
>> +			status = "disabled";
>> +		};
>
> On second thought, any reason we don't want this enabled by default?

Please see my answer to Geert [1].
After reconsideration, maybe it is advisable to enable it by default. Enabling
ECC is done by the bootloader, and it might be better if no further actions are
required to enable it kernel side.
If ECC is disabled, no errors will be generated, and the capabilties will just be
set to EDAC_CAP_NONE.

[1]: https://lore.kernel.org/all/DM3OXV8IQQKR.36V79A742H52F@bootlin.com/

Thanks.
Best regards,
-- 
Paul Louvel, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


      reply	other threads:[~2026-11-17 13:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19 14:43 [PATCH v7 0/3] Add Renesas RZ/N1x EDAC driver Paul Louvel
2026-10-19 14:43 ` [PATCH v7 1/3] dt-bindings: edac: cdns,ddr-edac: add Cadence DDR EDAC Paul Louvel
2026-10-19 14:43 ` [PATCH v7 2/3] EDAC/cadence: Add Cadence DDR EDAC driver Paul Louvel
2026-11-17 13:07   ` Wolfram Sang
2026-10-19 14:43 ` [PATCH v7 3/3] ARM: dts: renesas: r9a06g032: add EDAC node Paul Louvel
2026-11-17 13:08   ` Wolfram Sang
2026-11-17 13:46     ` Paul Louvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMXJ5VMIPGL9.1917ON486UJRD@bootlin.com \
    --to=paul.louvel@bootlin.com \
    --cc=bp@alien8.de \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=herve.codina@bootlin.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=robh@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tony.luck@intel.com \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox