From: Borislav Petkov <bp@alien8.de>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Yazen Ghannam <yazen.ghannam@amd.com>, Tom Rix <trix@redhat.com>,
tony.luck@intel.com, james.morse@arm.com, mchehab@kernel.org,
rric@kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] EDAC/amd64: Shut up an -Werror,-Wsometimes-uninitialized clang false positive
Date: Tue, 14 Feb 2023 10:55:51 +0100 [thread overview]
Message-ID: <Y+tapzerW7h9vMvp@zn.tnic> (raw)
In-Reply-To: <Y+q2pXYI02qAje8N@dev-arch.thelio-3990X>
From: Yazen Ghannam <yazen.ghannam@amd.com>
Yeah, the code's fine even without this.
What this is fixing is a compiler which is overeager to report false
positives which then get automatically enabled in -Wall builds and when
CONFIG_WERROR is set in allmodconfig builds, the build fails.
It doesn't happen with gcc.
Maybe clang should be more conservative when enabling such warnings
under -Wall as, apparently, this has an impact beyond just noisy output.
[ bp: Write a commit message. ]
Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/Y%2BqdVHidnrrKvxiD@dev-arch.thelio-3990X
---
drivers/edac/amd64_edac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index 1c4bef1cdf28..5b42533f306a 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -3928,7 +3928,7 @@ static const struct attribute_group *amd64_edac_attr_groups[] = {
static int hw_info_get(struct amd64_pvt *pvt)
{
- u16 pci_id1, pci_id2;
+ u16 pci_id1 = 0, pci_id2 = 0;
int ret;
if (pvt->fam >= 0x17) {
--
2.35.1
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2023-02-14 9:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 19:15 [PATCH] EDAC/amd64: remove unneeded call to reserve_mc_sibling_devs() Tom Rix
2023-02-13 20:12 ` Yazen Ghannam
2023-02-13 20:23 ` Borislav Petkov
2023-02-13 20:28 ` Nathan Chancellor
2023-02-13 21:17 ` Tom Rix
2023-02-13 22:11 ` Yazen Ghannam
2023-02-13 22:16 ` Nathan Chancellor
2023-02-14 9:55 ` Borislav Petkov [this message]
2023-02-14 14:32 ` [PATCH] EDAC/amd64: Shut up an -Werror,-Wsometimes-uninitialized clang false positive Nathan Chancellor
2023-02-14 15:04 ` Yazen Ghannam
2023-02-14 16:27 ` Nathan Chancellor
2023-02-14 16:38 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+tapzerW7h9vMvp@zn.tnic \
--to=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nathan@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=trix@redhat.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox