From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7318CFA373E for ; Wed, 26 Oct 2022 16:00:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234389AbiJZQAk (ORCPT ); Wed, 26 Oct 2022 12:00:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234527AbiJZQA2 (ORCPT ); Wed, 26 Oct 2022 12:00:28 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04FEE5F6C; Wed, 26 Oct 2022 09:00:25 -0700 (PDT) Received: from zn.tnic (p200300ea9733e7b8329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e7b8:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 02D601EC0380; Wed, 26 Oct 2022 18:00:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1666800024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=DXc4jkHehf/K9aHVR9Jvxnesj3jpdj9/1OFuugesUOw=; b=PpyQccF3qnTNA0Gt7sqseRLewddUW1h1Dnn+NjriMojMfN6ZEb1AAJ5RYlnscYT8N1x4a7 Sypwz5pEHx7Nq1aLWjlUq2QWa78q/wD9HeqdIAwNXxiDZoMyymxcBUpwDHGm2y3XteQX+x Zys28ruK/rjn0sPmITd+3awOPMdxe+4= Date: Wed, 26 Oct 2022 18:00:20 +0200 From: Borislav Petkov To: Manivannan Sadhasivam Cc: bjorn.andersson@linaro.org, mchehab@kernel.org, james.morse@arm.com, rric@kernel.org, linux-arm-msm@vger.kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, quic_tsoni@quicinc.com, quic_saipraka@quicinc.com Subject: Re: [PATCH v3 3/5] EDAC/qcom: Get rid of hardcoded register offsets Message-ID: References: <20220825043859.30066-1-manivannan.sadhasivam@linaro.org> <20220825043859.30066-4-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220825043859.30066-4-manivannan.sadhasivam@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org On Thu, Aug 25, 2022 at 10:08:57AM +0530, Manivannan Sadhasivam wrote: > The LLCC EDAC register offsets varies between each SoC. Hardcoding the > register offsets won't work and will often result in crash due to > accessing the wrong locations. > > Hence, get the register offsets from the LLCC driver matching the > individual SoCs. > > Signed-off-by: Manivannan Sadhasivam > --- > drivers/edac/qcom_edac.c | 116 ++++++++++++++--------------- > include/linux/soc/qcom/llcc-qcom.h | 6 -- > 2 files changed, 58 insertions(+), 64 deletions(-) I can't take those: ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/soc/qcom/llcc-qcom.ko] undefined! make[1]: *** [scripts/Makefile.modpost:126: Module.symvers] Error 1 make: *** [Makefile:1944: modpost] Error 2 You'd have to rediff them against latest Linus -rc tag and test them properly. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette